Skip to content

[FLINK-29495][Connector/Pulsar] Refactor Pulsar tests to disable them on Java 11 #21005

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MartijnVisser merged 2 commits into from
Oct 10, 2022
Merged

[FLINK-29495][Connector/Pulsar] Refactor Pulsar tests to disable them on Java 11 #21005

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
be32edd
[FLINK-29495][Connector/Pulsar] Refactor Pulsar tests from JUnit4 ann…
MartijnVisser Oct 10, 2022
c7a8408
[hotfix][test] Refactor test to use correct syntax for JUnit5 annotation
MartijnVisser Oct 10, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...or-files/src/test/java/org/apache/flink/connector/file/src/FileSourceTextLinesITCase.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -169,7 +169,7 @@ void testContinuousTextFileSource(
* record format (text lines) and restarts TaskManager.
*/
@Test
@Tag("FailsWithAdaptiveScheduler.class") // FLINK-21450
@Tag("org.apache.flink.testutils.junit.FailsWithAdaptiveScheduler") // FLINK-21450
void testContinuousTextFileSourceWithTaskManagerFailover(
@TempDir java.nio.file.Path tmpTestDir, @InjectMiniCluster MiniCluster miniCluster)
throws Exception {
Expand Down
5 changes: 2 additions & 3 deletions ...nnector-pulsar/src/test/java/org/apache/flink/connector/pulsar/sink/PulsarSinkITCase.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,11 +37,10 @@
import org.apache.flink.streaming.api.CheckpointingMode;
import org.apache.flink.streaming.api.environment.StreamExecutionEnvironment;
import org.apache.flink.test.junit5.MiniClusterExtension;
import org.apache.flink.testutils.junit.FailsOnJava11;
import org.apache.flink.testutils.junit.SharedObjectsExtension;

import org.junit.experimental.categories.Category;
import org.junit.jupiter.api.Nested;
import org.junit.jupiter.api.Tag;
import org.junit.jupiter.api.extension.RegisterExtension;
import org.junit.jupiter.params.ParameterizedTest;
import org.junit.jupiter.params.provider.EnumSource;
Expand All @@ -55,7 +54,7 @@
import static org.assertj.core.api.Assertions.assertThat;

/** Tests for using PulsarSink writing to a Pulsar cluster. */
@Category(value = {FailsOnJava11.class})
@Tag("org.apache.flink.testutils.junit.FailsOnJava11")
class PulsarSinkITCase {

/** Integration test based on connector testing framework. */
Expand Down
5 changes: 2 additions & 3 deletions ...tor-pulsar/src/test/java/org/apache/flink/connector/pulsar/source/PulsarSourceITCase.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,16 +30,15 @@
import org.apache.flink.connector.testframe.junit.annotations.TestSemantics;
import org.apache.flink.connector.testframe.testsuites.SourceTestSuiteBase;
import org.apache.flink.streaming.api.CheckpointingMode;
import org.apache.flink.testutils.junit.FailsOnJava11;

import org.apache.pulsar.client.api.SubscriptionType;
import org.junit.experimental.categories.Category;
import org.junit.jupiter.api.Tag;

/**
* Unit test class for {@link PulsarSource}. Used for {@link SubscriptionType#Exclusive}
* subscription.
*/
@Category(value = {FailsOnJava11.class})
@Tag("org.apache.flink.testutils.junit.FailsOnJava11")
class PulsarSourceITCase extends SourceTestSuiteBase<String> {

// Defines test environment on Flink MiniCluster
Expand Down
5 changes: 2 additions & 3 deletions ...r/src/test/java/org/apache/flink/connector/pulsar/source/PulsarUnorderedSourceITCase.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,15 +30,14 @@
import org.apache.flink.connector.testframe.junit.annotations.TestExternalSystem;
import org.apache.flink.connector.testframe.junit.annotations.TestSemantics;
import org.apache.flink.streaming.api.CheckpointingMode;
import org.apache.flink.testutils.junit.FailsOnJava11;

import org.apache.pulsar.client.api.SubscriptionType;
import org.junit.experimental.categories.Category;
import org.junit.jupiter.api.Tag;

/**
* Unit test class for {@link PulsarSource}. Used for {@link SubscriptionType#Shared} subscription.
*/
@Category(value = {FailsOnJava11.class})
@Tag("org.apache.flink.testutils.junit.FailsOnJava11")
public class PulsarUnorderedSourceITCase extends UnorderedSourceTestSuiteBase<String> {

// Defines test environment on Flink MiniCluster
Expand Down
5 changes: 2 additions & 3 deletions ...-end-tests-pulsar/src/test/java/org/apache/flink/tests/util/pulsar/PulsarSinkE2ECase.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,13 +28,12 @@
import org.apache.flink.streaming.api.CheckpointingMode;
import org.apache.flink.tests.util.pulsar.common.FlinkContainerWithPulsarEnvironment;
import org.apache.flink.tests.util.pulsar.common.PulsarContainerTestEnvironment;
import org.apache.flink.testutils.junit.FailsOnJava11;

import org.junit.experimental.categories.Category;
import org.junit.jupiter.api.Tag;

/** Pulsar sink E2E test based on connector testing framework. */
@SuppressWarnings("unused")
@Category(value = {FailsOnJava11.class})
@Tag("org.apache.flink.testutils.junit.FailsOnJava11")
public class PulsarSinkE2ECase extends PulsarSinkTestSuiteBase {

@TestSemantics
Expand Down
5 changes: 2 additions & 3 deletions ...s-pulsar/src/test/java/org/apache/flink/tests/util/pulsar/PulsarSourceOrderedE2ECase.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,16 +29,15 @@
import org.apache.flink.tests.util.pulsar.common.PulsarContainerTestEnvironment;
import org.apache.flink.tests.util.pulsar.source.ExclusiveSubscriptionContext;
import org.apache.flink.tests.util.pulsar.source.FailoverSubscriptionContext;
import org.apache.flink.testutils.junit.FailsOnJava11;

import org.junit.experimental.categories.Category;
import org.junit.jupiter.api.Tag;

/**
* Pulsar E2E test based on connector testing framework. It's used for Failover & Exclusive
* subscription.
*/
@SuppressWarnings("unused")
@Category(value = {FailsOnJava11.class})
@Tag("org.apache.flink.testutils.junit.FailsOnJava11")
public class PulsarSourceOrderedE2ECase extends SourceTestSuiteBase<String> {

// Defines the Semantic.
Expand Down
5 changes: 2 additions & 3 deletions ...pulsar/src/test/java/org/apache/flink/tests/util/pulsar/PulsarSourceUnorderedE2ECase.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,16 +29,15 @@
import org.apache.flink.streaming.api.CheckpointingMode;
import org.apache.flink.tests.util.pulsar.common.FlinkContainerWithPulsarEnvironment;
import org.apache.flink.tests.util.pulsar.common.PulsarContainerTestEnvironment;
import org.apache.flink.testutils.junit.FailsOnJava11;

import org.junit.experimental.categories.Category;
import org.junit.jupiter.api.Tag;

/**
* Pulsar E2E test based on connector testing framework. It's used for Shared & Key_Shared
* subscription.
*/
@SuppressWarnings("unused")
@Category(value = {FailsOnJava11.class})
@Tag("org.apache.flink.testutils.junit.FailsOnJava11")
public class PulsarSourceUnorderedE2ECase extends UnorderedSourceTestSuiteBase<String> {

// Defines the Semantic.
Expand Down