[FLINK-29509] Set proper subtaskId and numberOfSubtasks on CheckpointCommittableManagerImpl during recovery/deserialization. #21030
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ointCommittableManagerImpl during deserialization. When we recover the `CheckpointCommittableManager` we were ignoring the subtaskId it is recovered on. This becomes a problem when a sink uses a post-commit topology because multiple committer operators might forward committable summaries coming from the same subtaskId. This ticket implements a fix to use the subtaskId already present in the CommittableCollectorSerializer when recreating CheckpointCommittableManagerImpl during recovery. Signed-off-by: Krzysztof Chmielewski <krzysiek.chmielewski@gmail.com>
Collaborator
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
Unchanged backport of PR_20979
Fixing FLINK-29509 by setting the correct
subtaskIdandnumberOfSubtasksforCheckpointCommittableManagerImplduring recovery of committables for Sink V2 architecture.Brief change log
CheckpointCommittableManagerImplthat was previously used only during deserialization and replace it with a new one that acceptsMap<Integer, SubtaskCommittableManager<CommT>> subtasksCommittableManagersalong withsubtaskIdandnumberOfSubtasks.CheckpointCommittableManagerImplconstructor inCommittableCollectorSerializerdeserialize method forCheckpointCommittableManagerImplpassingsubtaskIdandnumberOfSubtasksfrom serializer instance.Verifying this change
This changed enhanced existing
CommittableCollectorSerializerTest::testCommittableCollectorV2SerDe()test by verifyingsybtaskIdandnumberOfSubtasksondeserialized CheckpointCommittableManagerImplinstance.Does this pull request potentially affect one of the following parts:
@Public(Evolving): (no)Documentation