-
Notifications
You must be signed in to change notification settings - Fork 13.8k
[FLINK-29615] Retain active subtasks in TaskMetricStore when fetching metrics to accommodate dynamic scaling #21051
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Contributor
Author
|
@flinkbot run azure |
… metrics to accommodate dynamic scaling
Contributor
Author
|
@flinkbot run azure |
xintongsong
approved these changes
Oct 20, 2022
Contributor
xintongsong
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Contributor
|
@flinkbot run azure |
xintongsong
pushed a commit
that referenced
this pull request
Oct 21, 2022
… fetching metrics to accommodate dynamic scaling This closes #21051
huangxiaofeng10047
pushed a commit
to huangxiaofeng10047/flink
that referenced
this pull request
Nov 3, 2022
… fetching metrics to accommodate dynamic scaling This closes apache#21051
dchristle
pushed a commit
to dchristle/flink
that referenced
this pull request
Nov 18, 2022
… fetching metrics to accommodate dynamic scaling This closes apache#21051
sergeitsar
pushed a commit
to fentik/flink
that referenced
this pull request
Feb 8, 2023
… fetching metrics to accommodate dynamic scaling This closes apache#21051
sergeitsar
pushed a commit
to fentik/flink
that referenced
this pull request
Feb 8, 2023
… fetching metrics to accommodate dynamic scaling This closes apache#21051
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
(For example: This pull request makes task deployment go through the blob server, rather than through RPC. That way we avoid re-transferring them on each deployment (during recovery).)
This pull request removes metrics of nonexistent subtasks when adaptive scheduler lowers job parallelism (aka, num of subtasks decreases).
Brief change log
Thanks to FLINK-29132 & FLINK-28588, Flink will now update current execution attempts when updating metrics. Since the active subtask info is included in the current execution attempt info, we are able to retain active subtasks using the current execution attempt info.
Verifying this change
Added UT to test the case where the number of subtasks decrease and tested on standalone clusters as the following:
Does this pull request potentially affect one of the following parts:
@Public(Evolving): (yes / no) noDocumentation