Skip to content

Conversation

@X-czh
Copy link
Contributor

@X-czh X-czh commented Oct 13, 2022

What is the purpose of the change

(For example: This pull request makes task deployment go through the blob server, rather than through RPC. That way we avoid re-transferring them on each deployment (during recovery).)

This pull request removes metrics of nonexistent subtasks when adaptive scheduler lowers job parallelism (aka, num of subtasks decreases).

Brief change log

Thanks to FLINK-29132 & FLINK-28588, Flink will now update current execution attempts when updating metrics. Since the active subtask info is included in the current execution attempt info, we are able to retain active subtasks using the current execution attempt info.

Verifying this change

Added UT to test the case where the number of subtasks decrease and tested on standalone clusters as the following:

  1. Start a job with reactive mode enabled on a standalone cluster.
  2. Remove TMs to decrease parallelism.
  3. Checked that extra subtasks are removed in backpressure monitoring page.

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): (yes / no) no
  • The public API, i.e., is any changed class annotated with @Public(Evolving): (yes / no) no
  • The serializers: (yes / no / don't know) no
  • The runtime per-record code paths (performance sensitive): (yes / no / don't know) no
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (yes / no / don't know) no
  • The S3 file system connector: (yes / no / don't know) no

Documentation

  • Does this pull request introduce a new feature? (yes / no) no
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)

@flinkbot
Copy link
Collaborator

flinkbot commented Oct 13, 2022

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

@X-czh
Copy link
Contributor Author

X-czh commented Oct 13, 2022

@flinkbot run azure

@X-czh
Copy link
Contributor Author

X-czh commented Oct 13, 2022

@flinkbot run azure

Copy link
Contributor

@xintongsong xintongsong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@xintongsong
Copy link
Contributor

@flinkbot run azure

xintongsong pushed a commit that referenced this pull request Oct 21, 2022
… fetching metrics to accommodate dynamic scaling

This closes #21051
@X-czh X-czh deleted the FLINK-29615 branch October 21, 2022 09:31
huangxiaofeng10047 pushed a commit to huangxiaofeng10047/flink that referenced this pull request Nov 3, 2022
… fetching metrics to accommodate dynamic scaling

This closes apache#21051
dchristle pushed a commit to dchristle/flink that referenced this pull request Nov 18, 2022
… fetching metrics to accommodate dynamic scaling

This closes apache#21051
sergeitsar pushed a commit to fentik/flink that referenced this pull request Feb 8, 2023
… fetching metrics to accommodate dynamic scaling

This closes apache#21051
sergeitsar pushed a commit to fentik/flink that referenced this pull request Feb 8, 2023
… fetching metrics to accommodate dynamic scaling

This closes apache#21051
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants