Skip to content

[STRMHELP-230] Metric Collision#21060

Closed
sethsaperstein-lyft wants to merge 41 commits into
apache:release-1.13from
lyft:STRMHELP-230_metric_collision
Closed

[STRMHELP-230] Metric Collision#21060
sethsaperstein-lyft wants to merge 41 commits into
apache:release-1.13from
lyft:STRMHELP-230_metric_collision

Conversation

@sethsaperstein-lyft
Copy link
Copy Markdown
Contributor

overview

Define gauge metric once during KinesisDataFetcher init to avoid reinstantiating and thus causing naming collision

What is the purpose of the change

(For example: This pull request makes task deployment go through the blob server, rather than through RPC. That way we avoid re-transferring them on each deployment (during recovery).)

Brief change log

(for example:)

  • The TaskInfo is stored in the blob store on job creation time as a persistent artifact
  • Deployments RPC transmits only the blob storage reference
  • TaskManagers retrieve the TaskInfo from the blob cache

Verifying this change

Please make sure both new and modified tests in this PR follows the conventions defined in our code quality guide: https://flink.apache.org/contributing/code-style-and-quality-common.html#testing

(Please pick either of the following options)

This change is a trivial rework / code cleanup without any test coverage.

(or)

This change is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(example:)

  • Added integration tests for end-to-end deployment with large payloads (100MB)
  • Extended integration test for recovery after master (JobManager) failure
  • Added test that validates that TaskInfo is transferred only once across recoveries
  • Manually verified the change by running a 4 node cluster with 2 JobManagers and 4 TaskManagers, a stateful streaming program, and killing one JobManager and two TaskManagers during the execution, verifying that recovery happens correctly.

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): (yes / no)
  • The public API, i.e., is any changed class annotated with @Public(Evolving): (yes / no)
  • The serializers: (yes / no / don't know)
  • The runtime per-record code paths (performance sensitive): (yes / no / don't know)
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (yes / no / don't know)
  • The S3 file system connector: (yes / no / don't know)

Documentation

  • Does this pull request introduce a new feature? (yes / no)
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)

maghamravi and others added 30 commits September 17, 2021 18:42
Add `python_requires` to Flink setup.cfg
Translate version to be compatible with Java build
Copy Hive JAR into apache-flink-libraries build
Read/write JAR to lib directory
Revert unlinking before symlink
Stop explicitly calling out JAR
Revert "update zk version to 3.5.6"
maghamravi and others added 11 commits August 9, 2022 12:29
[RTOP-645] [backport] Job and Execution status metrics
…sm is higher than partitions in KafkaSource

Before this commit the enumerator signalled the leftover source readers
without a partition to finish. This caused that checkpointing was not
possible anymore because it is only supported if all tasks are running
or FLIP-147 is enabled.

This closes apache#17330
[STRMHELP-206] [FLINK-24347] [backport]
apache flink libraries version
* add getter for global watermark manager

* DRY

* DRY test

* additional logging and feature flag

* fix log

* metric for isIdle

* change noOp to updateLocalWatermark

* remove unused import
* bump zk version

* update to 3.5.10

* Commit for release 1.13-lyft202209211663788204

* try to make proper zk version available

* Revert "Commit for release 1.13-lyft202209211663788204"

This reverts commit c0fc93f.

* Commit for release 1.13-lyft202209211663790698

* Revert "Commit for release 1.13-lyft202209211663790698"

This reverts commit 086ef31.

* change to flink 3.5.6
Unpin `cloudpickle` in Lyft 1.13 Release
@sethsaperstein-lyft sethsaperstein-lyft changed the base branch from master to release-1.13 October 14, 2022 06:25
@sethsaperstein-lyft sethsaperstein-lyft deleted the STRMHELP-230_metric_collision branch October 14, 2022 06:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants