Skip to content

Conversation

@rgsriram
Copy link
Contributor

What is the purpose of the change

Flink docs don't have any documentation link related to Flink Kubernetes operator. This change lets us see the Flink Kubernetes operator and how to use it.

Brief change log

  • Added documentation links for Flink Kubernetes operator.

Verifying this change

This change is a trivial rework/code cleanup without any test coverage. I added new documentation links.

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): no
  • The public API, i.e., is any changed class annotated with @Public(Evolving): no
  • The serializers: no
  • The runtime per-record code paths (performance sensitive): no
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
  • The S3 file system connector: no

Documentation

  • Does this pull request introduces a new feature? no
  • If yes, how is the feature documented? not applicable

@flinkbot
Copy link
Collaborator

flinkbot commented Oct 18, 2022

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

@rgsriram rgsriram requested a review from gyfora October 18, 2022 13:22
Copy link
Contributor

@gyfora gyfora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should have the following simplified text in both places:

Apache Flink also provides a Kubernetes operator for managing Flink clusters on Kubernetes. It supports both standalone and native deployment mode and greatly simplifies deployment, configuration and the life cycle management of Flink resources on Kubernetes.

For more information, please refer to the [Flink Kubernetes Operator documentation](https://nightlies.apache.org/flink/flink-kubernetes-operator-docs-main/docs/concepts/overview/)

@rgsriram rgsriram requested a review from gyfora October 18, 2022 14:28
@gyfora
Copy link
Contributor

gyfora commented Oct 18, 2022

Can you please always squash/rebase commits instead of merging? Makes review and later merging easier

@rgsriram rgsriram closed this Oct 18, 2022
[FLINK-29644] Added flink kubernetes operator documentation links

[FLINK-29644] Added flink kubernetes operator documentation links

[FLINK-29644] Added flink kubernetes operator documentation links
@rgsriram
Copy link
Contributor Author

Squashed multiple commits into one.

@rgsriram rgsriram reopened this Oct 18, 2022
@rgsriram
Copy link
Contributor Author

@gyfora - Do you think creating a separate PR with only this commit would be a good way instead squashing all commits into one? Please let me know.

@gyfora
Copy link
Contributor

gyfora commented Oct 19, 2022

looks fine +1, I am going to merge this. Please open the same PR against release-1.16 and release-1.15 branches so we can have this in all version of the docs

@gyfora gyfora merged commit 8f3eab2 into apache:master Oct 19, 2022
@rgsriram
Copy link
Contributor Author

rgsriram commented Oct 19, 2022 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants