Skip to content

[FLINK-29587][planner] fix planer fail to simplify conjunctive exclusiveFilter#21094

Closed
luoyuxia wants to merge 1 commit intoapache:masterfrom
luoyuxia:FLINK-29587
Closed

[FLINK-29587][planner] fix planer fail to simplify conjunctive exclusiveFilter#21094
luoyuxia wants to merge 1 commit intoapache:masterfrom
luoyuxia:FLINK-29587

Conversation

@luoyuxia
Copy link
Contributor

@luoyuxia luoyuxia commented Oct 18, 2022

What is the purpose of the change

Make the logic in RexSimplify.java#residue robust to resolve the case the literal is the first operand and field ref is the second operand like
200 = a.

Brief change log

  • add an extra check for the case that the first operand if literal and the second operand is field ref.

Verifying this change

Added test in CalTest#testConjunctiveExclusiveFilter

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): (yes / no)
  • The public API, i.e., is any changed class annotated with @Public(Evolving): (yes / no)
  • The serializers: (yes / no / don't know)
  • The runtime per-record code paths (performance sensitive): (yes / no / don't know)
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (yes / no / don't know)
  • The S3 file system connector: (yes / no / don't know)

Documentation

  • Does this pull request introduce a new feature? (yes / no)
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)

@flinkbot
Copy link
Collaborator

flinkbot commented Oct 18, 2022

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

…when literal is first operand and field ref is the second
@github-actions
Copy link

This PR is being marked as stale since it has not had any activity in the last 180 days.
If you would like to keep this PR alive, please leave a comment asking for a review.
If the PR has merge conflicts, update it with the latest from the base branch.

If you are having difficulty finding a reviewer, please reach out to the [community](https://flink.apache.org/what-is-flink/community/).

If this PR is no longer valid or desired, please feel free to close it. If no activity occurs in the next 90 days, it will be automatically closed.

@github-actions github-actions bot added the stale label Jan 15, 2025
@github-actions
Copy link

github-actions bot commented Apr 1, 2025

This PR has been closed since it has not had any activity in 120 days.
If you feel like this was a mistake, or you would like to continue working on it,
please feel free to re-open the PR and ask for a review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants