-
Notifications
You must be signed in to change notification settings - Fork 13.8k
[FLINK-29664][runtime] Collect subpartition sizes of blocking result partitions #21111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
157f08a to
30f3963
Compare
f33b535 to
54ac216
Compare
...c/test/java/org/apache/flink/runtime/executiongraph/DefaultExecutionGraphDeploymentTest.java
Outdated
Show resolved
Hide resolved
...e/src/main/java/org/apache/flink/runtime/io/network/metrics/ResultPartitionBytesCounter.java
Outdated
Show resolved
Hide resolved
...e/src/main/java/org/apache/flink/runtime/io/network/metrics/ResultPartitionBytesCounter.java
Outdated
Show resolved
Hide resolved
flink-runtime/src/main/java/org/apache/flink/runtime/executiongraph/IOMetrics.java
Show resolved
Hide resolved
...e/src/main/java/org/apache/flink/runtime/scheduler/adaptivebatch/AdaptiveBatchScheduler.java
Outdated
Show resolved
Hide resolved
flink-runtime/src/main/java/org/apache/flink/runtime/executiongraph/IOMetrics.java
Show resolved
Hide resolved
flink-runtime/src/main/java/org/apache/flink/runtime/executiongraph/IOMetrics.java
Show resolved
Hide resolved
...e/src/main/java/org/apache/flink/runtime/scheduler/adaptivebatch/AdaptiveBatchScheduler.java
Outdated
Show resolved
Hide resolved
...ntime/src/main/java/org/apache/flink/runtime/scheduler/adaptivebatch/BlockingResultInfo.java
Outdated
Show resolved
Hide resolved
...c/main/java/org/apache/flink/runtime/scheduler/adaptivebatch/AllToAllBlockingResultInfo.java
Outdated
Show resolved
Hide resolved
|
Thanks for review @zhuzhurk. I 've addressed or replied all comments. Please take a look. |
4f21172 to
091ccc6
Compare
79aa9ef to
3208f08
Compare
|
I measured the space usage of |
...e/src/main/java/org/apache/flink/runtime/scheduler/adaptivebatch/AdaptiveBatchScheduler.java
Outdated
Show resolved
Hide resolved
...e/src/main/java/org/apache/flink/runtime/scheduler/adaptivebatch/AdaptiveBatchScheduler.java
Outdated
Show resolved
Hide resolved
...c/main/java/org/apache/flink/runtime/scheduler/adaptivebatch/AllToAllBlockingResultInfo.java
Outdated
Show resolved
Hide resolved
.../main/java/org/apache/flink/runtime/scheduler/adaptivebatch/PointwiseBlockingResultInfo.java
Outdated
Show resolved
Hide resolved
...c/test/java/org/apache/flink/runtime/scheduler/adaptivebatch/AdaptiveBatchSchedulerTest.java
Show resolved
Hide resolved
...c/main/java/org/apache/flink/runtime/scheduler/adaptivebatch/AllToAllBlockingResultInfo.java
Outdated
Show resolved
Hide resolved
zhuzhurk
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for addressing all the comments.
LGTM.
3f9d40c to
7ef94bb
Compare
8b47815 to
3292157
Compare
What is the purpose of the change
Collect subpartition sizes of blocking result partitions
Verifying this change
Some unit tests.
Does this pull request potentially affect one of the following parts:
@Public(Evolving): (no)Documentation