Skip to content

Conversation

@wanglijie95
Copy link
Contributor

What is the purpose of the change

Collect subpartition sizes of blocking result partitions

Verifying this change

Some unit tests.

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): (no)
  • The public API, i.e., is any changed class annotated with @Public(Evolving): (no)
  • The serializers: (no)
  • The runtime per-record code paths (performance sensitive): (no)
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (no)
  • The S3 file system connector: (no)

Documentation

  • Does this pull request introduce a new feature? (no)
  • If yes, how is the feature documented? (not applicable)

@flinkbot
Copy link
Collaborator

flinkbot commented Oct 19, 2022

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

@wanglijie95
Copy link
Contributor Author

Thanks for review @zhuzhurk. I 've addressed or replied all comments. Please take a look.

@wanglijie95 wanglijie95 force-pushed the FLINK-29664 branch 2 times, most recently from 4f21172 to 091ccc6 Compare October 31, 2022 22:33
@wanglijie95 wanglijie95 requested a review from zhuzhurk November 9, 2022 16:42
@wanglijie95
Copy link
Contributor Author

I measured the space usage of AllToAllBlockingResultInfo on a real cluster. For an A -> B test job, where A -> B is an all-to-all edge, we test the space occupancy of 1024*1024(1024 partitions and each partition has 1024 subpartitons) and 8192*8192:
1024*1024 : 8.07 MB
8192*8192 : 513 MB

Copy link
Contributor

@zhuzhurk zhuzhurk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for addressing all the comments.
LGTM.

@wanglijie95 wanglijie95 deleted the FLINK-29664 branch December 20, 2022 07:22
chucheng92 pushed a commit to chucheng92/flink that referenced this pull request Feb 3, 2023
akkinenivijay pushed a commit to krisnaru/flink that referenced this pull request Feb 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants