[Flink 29627][streaming] Fix duplicate key exception during recovery more than 1 committable. #21113
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… more than 1 committable. Recovery more than one Committable causes `IllegalStateException` and prevents cluster to start. When we recover the `CheckpointCommittableManager` we deserialize SubtaskCommittableManager instances from recovery state, and we put them into `Map<Integer, SubtaskCommittableManager<CommT>>`. The key of this map is subtaskId of the recovered manager. However, this will fail if we have to recover more than one committable. What was implemented as a fix is to call `SubtaskCommittableManager::merge` if we already deserialize manager for this subtaskId. Signed-off-by: Krzysztof Chmielewski <krzysiek.chmielewski@gmail.com>
Collaborator
kristoffSC
changed the title
Contributor
Author
|
@flinkbot run azure |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
Unchanged backport of #21101
Fixing FLINK-29627 where recovery more than one Committable causesed
IllegalStateExceptionand prevents cluster to start.Implemented fix is based on merging committables from same subtaskId during recovery for Sink V2 architecture.
Brief change log
CheckpointSimpleVersionedSerializer::deserializeby callingSubtaskCommittableManager::mergefor committables for same subtaskId.Verifying this change
Committablecollectorserializertest::testCommittablesForSameSubtaskIdV2SerDeto verify deserialization of multiple committables for the same subtaskId.CommitterOperatorTest::testStateRestoreto include committables for same subtaskId.Does this pull request potentially affect one of the following parts:
@Public(Evolving): (no)Documentation