Skip to content

Conversation

@snuyanzin
Copy link
Contributor

@snuyanzin snuyanzin commented Oct 25, 2022

What is the purpose of the change

The PR adds icon (was taken from https://flink.apache.org/material.html) which will be shown in Intellijidea toolbox or Intellijidea recent projects like
Screenshot from 2022-10-26 01-30-48
and
Screenshot from 2022-10-26 01-34-47

Similar change is applied to other opensource projects like
Gradle: gradle/gradle#12733
Junit5: junit-team/junit-framework#2240
Apache JMeter: apache/jmeter#579
Apache Calcite: apache/calcite#1897

Verifying this change

This change is a trivial rework / code cleanup without any test coverage.

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): ( no)
  • The public API, i.e., is any changed class annotated with @Public(Evolving): ( no)
  • The serializers: ( no)
  • The runtime per-record code paths (performance sensitive): ( no)
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: ( no )
  • The S3 file system connector: ( no )

Documentation

  • Does this pull request introduce a new feature? ( no)
  • If yes, how is the feature documented? (not applicable)

@flinkbot
Copy link
Collaborator

flinkbot commented Oct 25, 2022

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

@snuyanzin
Copy link
Contributor Author

@flinkbot run azure

@Samrat002
Copy link
Contributor

this is really cool 👍🏻

@MartijnVisser MartijnVisser self-assigned this Oct 27, 2022
Copy link
Contributor

@MartijnVisser MartijnVisser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like it, thanks :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants