[FLINK-29665][runtime] Support flexible subpartion range division #21162
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
wanglijie95
force-pushed
the
FLINK-29665
branch
2 times, most recently
from
8bc54ab to
80e07f5
Compare
zhuzhurk
reviewed
Dec 19, 2022
flink-runtime/src/main/java/org/apache/flink/runtime/executiongraph/SubpartitionIndexRange.java
Outdated
Show resolved
Hide resolved
flink-runtime/src/main/java/org/apache/flink/runtime/executiongraph/TaskInputInfo.java
Outdated
Show resolved
Hide resolved
flink-runtime/src/main/java/org/apache/flink/runtime/executiongraph/TaskInputInfo.java
Outdated
Show resolved
Hide resolved
flink-runtime/src/main/java/org/apache/flink/runtime/executiongraph/IntermediateResultInfo.java
Outdated
Show resolved
Hide resolved
flink-runtime/src/main/java/org/apache/flink/runtime/executiongraph/TaskInputInfo.java
Outdated
Show resolved
Hide resolved
...e/src/main/java/org/apache/flink/runtime/executiongraph/VertexInputInfoComputationUtils.java
Outdated
Show resolved
Hide resolved
flink-runtime/src/main/java/org/apache/flink/runtime/executiongraph/VertexInputInfoStore.java
Outdated
Show resolved
Hide resolved
flink-runtime/src/main/java/org/apache/flink/runtime/executiongraph/TaskInputInfo.java
Outdated
Show resolved
Hide resolved
...e/src/main/java/org/apache/flink/runtime/executiongraph/VertexInputInfoComputationUtils.java
Outdated
Show resolved
Hide resolved
...e/src/main/java/org/apache/flink/runtime/executiongraph/VertexInputInfoComputationUtils.java
Outdated
Show resolved
Hide resolved
wanglijie95
force-pushed
the
FLINK-29665
branch
2 times, most recently
from
dffff61 to
94c09a9
Compare
Contributor
Author
|
Thanks for review @zhuzhurk. I 've addressed all comments, please take a look. |
zhuzhurk
reviewed
Dec 29, 2022
| return isDynamicGraph | ||
| ? intermediateResult.getPartitions()[partitionIndex].getNumberOfSubpartitions() | ||
| : IntermediateResultPartition.NUM_SUBPARTITIONS_UNKNOWN; | ||
| // Note that this method should only be called for dynamic graph |
Contributor
There was a problem hiding this comment.
Better to explain why, e.g. this method is used to compute which sub-partitions a consumer vertex should consume, however, for non-dynamic graph it is not needed, and the number of sub-partitions is not decided at this stage, due to the execution edge are not created.
wanglijie95
force-pushed
the
FLINK-29665
branch
from
5fde448 to
713f7af
Compare
chucheng92
pushed a commit
to chucheng92/flink
that referenced
this pull request
Feb 3, 2023
akkinenivijay
pushed a commit
to krisnaru/flink
that referenced
this pull request
Feb 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
Support flexible subpartion range division
Verifying this change
Add some tests
Does this pull request potentially affect one of the following parts:
@Public(Evolving): (no)Documentation