Skip to content

Conversation

@JingGe
Copy link
Contributor

@JingGe JingGe commented Oct 27, 2022

What is the purpose of the change

Back port #21172 to master: Change the docs: FlinkKafkaConsumer is deprecated and will be removed with Flink 1.17 instead of 1.15 since Flink 1.16 has code freeze and will be released soon.

Brief change log

  • kafka.md
  • zh kafka.md

Verifying this change

This change is a trivial doc update without any test coverage.

@flinkbot
Copy link
Collaborator

flinkbot commented Oct 27, 2022

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

@JingGe JingGe force-pushed the hotfix-kafka-doc-1.16 branch 2 times, most recently from 103c4d4 to 52d6fb4 Compare October 28, 2022 18:29
@zentol
Copy link
Contributor

zentol commented Oct 31, 2022

Let's just remove that entire line; why document something like that if we aren't committing to it.

@zentol zentol self-assigned this Oct 31, 2022
…with Flink 1.17 instead of 1.15 since Flink 1.16 release branch has code freeze and will be released soon.
@JingGe JingGe force-pushed the hotfix-kafka-doc-1.16 branch from 52d6fb4 to 1cca1af Compare October 31, 2022 14:29
@JingGe
Copy link
Contributor Author

JingGe commented Oct 31, 2022

Removing the entire line is one option. Another option is that the content should be synced with older releases because nothing has been changed. We'd better let developers know that it will be removed soon, i.e. don't use it anymore.

After removing FlinkKafkaConsumer and (maybe) graduating some APIs(need discussion and voting), the content should be updated accordingly. Removing the entire line is one option but better would be pointing out that the FlinkKafkaConsumer has been removed with 1.17 to share the reference with customers, in case they are looking for FlinkKafkaConsumer and could not find it.

@JingGe
Copy link
Contributor Author

JingGe commented Oct 31, 2022

@flinkbot run azure

Copy link
Contributor

@PatrickRen PatrickRen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the patch @JingGe . LGTM. We can remove this line once the community accepts the removal of the legacy Kafka source and sink.

@PatrickRen PatrickRen merged commit 5d4a2b6 into apache:master Nov 1, 2022
@ngannt1710
Copy link

I use FlinkKafkaConsumer with two consumer and two partitions. But the two consumers receive the same message regardless of which partitions it is pushed to. Can you suggest me to help solve this problem?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants