Skip to content

Conversation

@leletan
Copy link
Contributor

@leletan leletan commented Oct 29, 2022

What is the purpose of the change

This pull request makes SavepointHandlers and CheckpointHandlers call to RestfulGateway using timeout from their ancestor LeaderRetrievalHandler, instead of RpcUtils.INF_TIMEOUT

Brief change log

Use rest time out instead of RpcUtils.INF_TIMEOUT Infinite timeout in SavepointHandlers and CheckpointHandlers

Verifying this change

This change is a trivial rework / code cleanup without any test coverage.

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): (no)
  • The public API, i.e., is any changed class annotated with @Public(Evolving): (no)
  • The serializers: (no)
  • The runtime per-record code paths (performance sensitive): (no)
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (no)
  • The S3 file system connector: (no)

Documentation

  • Does this pull request introduce a new feature? (no)
  • If yes, how is the feature documented? (not applicable)

@flinkbot
Copy link
Collaborator

flinkbot commented Oct 29, 2022

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

@leletan leletan marked this pull request as draft October 29, 2022 03:54
@leletan leletan closed this Nov 4, 2022
@leletan leletan deleted the refact_checkpoint_savepoint_trigger_timeout branch November 4, 2022 06:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants