Skip to content

Conversation

@syhily
Copy link
Contributor

@syhily syhily commented Oct 31, 2022

What is the purpose of the change

Update the Pulsar dependency to 2.10.2 to benefit of the fixes highlighted at apache/pulsar@v2.10.2 (release)

Brief change log

Update dependencies

Verifying this change

This change is a trivial rework / code cleanup without any test coverage.

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): (yes)
  • The public API, i.e., is any changed class annotated with @Public(Evolving): (no)
  • The serializers: (no)
  • The runtime per-record code paths (performance sensitive): (no)
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (no)
  • The S3 file system connector: (no)

Documentation

  • Does this pull request introduce a new feature? (no)
  • If yes, how is the feature documented? (not applicable)

@flinkbot
Copy link
Collaborator

flinkbot commented Oct 31, 2022

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

@syhily syhily force-pushed the pull/FLINK-29709 branch 3 times, most recently from 32f3839 to 7ebada2 Compare November 1, 2022 12:46
@tisonkun tisonkun self-requested a review November 1, 2022 14:06
Copy link
Member

@tisonkun tisonkun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Waiting for CI status...

@syhily
Copy link
Contributor Author

syhily commented Nov 1, 2022

KafkaShuffleExactlyOnceITCase breaks all my PRs. I don't know how to bypass it.

@tisonkun
Copy link
Member

tisonkun commented Nov 2, 2022

@flinkbot run azure

Copy link
Member

@tisonkun tisonkun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems the failure fails exactly on the Pulsar tests:

Nov 02 04:14:52 [ERROR] org.apache.flink.connector.pulsar.sink.writer.topic.TopicMetadataListenerTest  Time elapsed: 6.818 s  <<< ERROR!
Nov 02 04:14:52 java.lang.IllegalStateException: org.apache.pulsar.broker.PulsarServerException: java.util.concurrent.ExecutionException: java.lang.NoSuchMethodError: com.github.benmanes.caffeine.cache.AsyncLoadingCache.asMap()Ljava/util/concurrent/ConcurrentMap;
Nov 02 04:14:52 	at org.apache.flink.connector.pulsar.testutils.runtime.mock.PulsarMockRuntime.startUp(PulsarMockRuntime.java:60)
Nov 02 04:14:52 	at org.apache.flink.connector.pulsar.testutils.PulsarTestEnvironment.beforeAll(PulsarTestEnvironment.java:90)
Nov 02 04:14:52 	at org.junit.jupiter.engine.descriptor.ClassBasedTestDescriptor.lambda$invokeBeforeAllCallbacks$12(ClassBasedTestDescriptor.java:395)
Nov 02 04:14:52 	at org.junit.platform.engine.support.hierarchical.ThrowableCollector.execute(ThrowableCollector.java:73)
Nov 02 04:14:52 	at org.junit.jupiter.engine.descriptor.ClassBasedTestDescriptor.invokeBeforeAllCallbacks(ClassBasedTestDescriptor.java:395)
Nov 02 04:14:52 	at org.junit.jupiter.engine.descriptor.ClassBasedTestDescriptor.before(ClassBasedTestDescriptor.java:211)
Nov 02 04:14:52 	at org.junit.jupiter.engine.descriptor.ClassBasedTestDescriptor.before(ClassBasedTestDescriptor.java:84)
Nov 02 04:14:52 	at org.junit.platform.engine.support.hierarchical.NodeTestTask.lambda$executeRecursively$6(NodeTestTask.java:148)
Nov 02 04:14:52 	at org.junit.platform.engine.support.hierarchical.ThrowableCollector.execute(ThrowableCollector.java:73)
Nov 02 04:14:52 	at org.junit.platform.engine.support.hierarchical.NodeTestTask.lambda$executeRecursively$8(NodeTestTask.java:141)
Nov 02 04:14:52 	at org.junit.platform.engine.support.hierarchical.Node.around(Node.java:137)
Nov 02 04:14:52 	at org.junit.platform.engine.support.hierarchical.NodeTestTask.lambda$executeRecursively$9(NodeTestTask.java:139)
Nov 02 04:14:52 	at org.junit.platform.engine.support.hierarchical.ThrowableCollector.execute(ThrowableCollector.java:73)
Nov 02 04:14:52 	at org.junit.platform.engine.support.hierarchical.NodeTestTask.executeRecursively(NodeTestTask.java:138)
Nov 02 04:14:52 	at org.junit.platform.engine.support.hierarchical.NodeTestTask.execute(NodeTestTask.java:95)
Nov 02 04:14:52 	at org.junit.platform.engine.support.hierarchical.ForkJoinPoolHierarchicalTestExecutorService$ExclusiveTask.compute(ForkJoinPoolHierarchicalTestExecutorService.java:185)
Nov 02 04:14:52 	at org.junit.platform.engine.support.hierarchical.ForkJoinPoolHierarchicalTestExecutorService.invokeAll(ForkJoinPoolHierarchicalTestExecutorService.java:129)
Nov 02 04:14:52 	at org.junit.platform.engine.support.hierarchical.NodeTestTask.lambda$executeRecursively$6(NodeTestTask.java:155)
Nov 02 04:14:52 	at org.junit.platform.engine.support.hierarchical.ThrowableCollector.execute(ThrowableCollector.java:73)
Nov 02 04:14:52 	at org.junit.platform.engine.support.hierarchical.NodeTestTask.lambda$executeRecursively$8(NodeTestTask.java:141)
Nov 02 04:14:52 	at org.junit.platform.engine.support.hierarchical.Node.around(Node.java:137)
Nov 02 04:14:52 	at org.junit.platform.engine.support.hierarchical.NodeTestTask.lambda$executeRecursively$9(NodeTestTask.java:139)
Nov 02 04:14:52 	at org.junit.platform.engine.support.hierarchical.ThrowableCollector.execute(ThrowableCollector.java:73)
Nov 02 04:14:52 	at org.junit.platform.engine.support.hierarchical.NodeTestTask.executeRecursively(NodeTestTask.java:138)
Nov 02 04:14:52 	at org.junit.platform.engine.support.hierarchical.NodeTestTask.execute(NodeTestTask.java:95)
Nov 02 04:14:52 	at org.junit.platform.engine.support.hierarchical.ForkJoinPoolHierarchicalTestExecutorService$ExclusiveTask.compute(ForkJoinPoolHierarchicalTestExecutorService.java:185)
Nov 02 04:14:52 	at java.util.concurrent.RecursiveAction.exec(RecursiveAction.java:189)
Nov 02 04:14:52 	at java.util.concurrent.ForkJoinTask.doExec(ForkJoinTask.java:289)
Nov 02 04:14:52 	at java.util.concurrent.ForkJoinPool$WorkQueue.runTask(ForkJoinPool.java:1056)

Please take a look.

@tisonkun
Copy link
Member

tisonkun commented Nov 2, 2022

I guess the reason is that Pulsar service uses Java 11 or Java 17 so that some methods cannot be found when Flink uses Java 8.

@syhily
Copy link
Contributor Author

syhily commented Nov 2, 2022

Yep. I think you are right. We may have to override the caffeine or drop the mocked Pulsar instance by in favor of Test container.

@tisonkun
Copy link
Member

tisonkun commented Nov 4, 2022

@flinkbot run azure

Copy link
Member

@tisonkun tisonkun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merging...

@tisonkun tisonkun merged commit b5a4d48 into apache:master Nov 7, 2022
@syhily syhily deleted the pull/FLINK-29709 branch November 7, 2022 06:19
Rodger-zk pushed a commit to Rodger-zk/Rodger-zk-bkbase-flink that referenced this pull request Dec 3, 2024
Rodger-zk pushed a commit to Rodger-zk/Rodger-zk-bkbase-flink that referenced this pull request Dec 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants