Skip to content

Conversation

@NicoK
Copy link
Contributor

@NicoK NicoK commented Nov 3, 2022

What is the purpose of the change

Javadocs won't build when building for Java 11, e.g. like this:

./mvnw clean package javadoc:jar -Pjava11 -Pjava11-target -pl flink-dist -am -Drat.skip=true -Dcheckstyle.skip=true -Dspotless.apply.skip -DskipTests

Brief change log

  • add missing add-exports for java.rmi/sun.rmi.registry to make it work

Verifying this change

Verified with the build command from above

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): no
  • The public API, i.e., is any changed class annotated with @Public(Evolving): no
  • The serializers: no
  • The runtime per-record code paths (performance sensitive): no
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
  • The S3 file system connector: no

Documentation

  • Does this pull request introduce a new feature? no
  • If yes, how is the feature documented? not applicable

@NicoK NicoK requested a review from zentol November 3, 2022 12:28
@zentol zentol self-assigned this Nov 3, 2022
@flinkbot
Copy link
Collaborator

flinkbot commented Nov 3, 2022

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

Copy link
Contributor

@zentol zentol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good stuff; I thought we always had to bump the plugin! Maybe some other change removed the need in the meantime.

@NicoK
Copy link
Contributor Author

NicoK commented Nov 4, 2022

FYI: test failure is due to FLINK-25306

@NicoK NicoK merged commit e962c69 into apache:master Nov 4, 2022
@NicoK NicoK deleted the f15633 branch November 4, 2022 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants