Skip to content

Conversation

@Samrat002
Copy link
Contributor

What is the purpose of the change

Brief change log

Fix dependencies error

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): no
  • The public API, i.e., is any changed class annotated with @Public(Evolving): no
  • The serializers: no
  • The runtime per-record code paths (performance sensitive): (yes / no / don't know)
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
  • The S3 file system connector: no

Documentation

  • Does this pull request introduce a new feature? no

@Samrat002 Samrat002 changed the title [Flink][hive] Fix flink-sql-connector hive error [FLINK-29878][hive] Fix flink-sql-connector hive error Nov 4, 2022
@flinkbot
Copy link
Collaborator

flinkbot commented Nov 4, 2022

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

@Samrat002
Copy link
Contributor Author

@flinkbot run azure

@Samrat002 Samrat002 marked this pull request as draft November 5, 2022 19:19
<exclude>avro/shaded/com/google/**</exclude>
<exclude>org/apache/avro/**</exclude>
<exclude>META-INF/maven/org.apache.avro/**</exclude>
<exclude>org/apache/hadoop/hive/conf/HiveConf*</exclude>
Copy link
Contributor

@luoyuxia luoyuxia Nov 7, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can use that just as before:

<exclude>org/apache/hadoop/hive/conf/HiveConf.class</exclude>		

<exclude>org/apache/hadoop/hive/metastore/HiveMetaStoreClient.class</exclude>

@Samrat002
Copy link
Contributor Author

Samrat002 commented Nov 8, 2022

Nov 07 19:06:18 java.lang.AssertionError: Create test topic : partition_failure_recovery_EventTime failed, org.apache.kafka.common.errors.TopicExistsException: Topic 'partition_failure_recovery_EventTime' already exists.
Nov 07 19:06:18 	at org.apache.flink.streaming.connectors.kafka.KafkaTestEnvironmentImpl.createTestTopic(KafkaTestEnvironmentImpl.java:207)
Nov 07 19:06:18 	at org.apache.flink.streaming.connectors.kafka.KafkaTestEnvironment.createTestTopic(KafkaTestEnvironment.java:97)
Nov 07 19:06:18 	at org.apache.flink.streaming.connectors.kafka.KafkaTestBase.createTestTopic(KafkaTestBase.java:217)
Nov 07 19:06:18 	at org.apache.flink.streaming.connectors.kafka.shuffle.KafkaShuffleExactlyOnceITCase.testAssignedToPartitionFailureRecovery(KafkaShuffleExactlyOnceITCase.java:158)
Nov 07 19:06:18 	at org.apache.flink.streaming.connectors.kafka.shuffle.KafkaShuffleExactlyOnceITCase.testAssignedToPartitionFailureRecoveryEventTime(KafkaShuffleExactlyOnceITCase.java:101)
Nov 07 19:06:18 	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)

not related test failure !

@luoyuxia please review the changes

@Samrat002 Samrat002 marked this pull request as ready for review November 8, 2022 04:24
@Samrat002 Samrat002 requested a review from luoyuxia November 8, 2022 04:24
Copy link
Contributor

@luoyuxia luoyuxia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Samrat002 Thanks for fix. LGTM

@luoyuxia
Copy link
Contributor

luoyuxia commented Nov 8, 2022

@flinkbot run azure

@dannycranmer
Copy link
Contributor

LGTM, thanks @Samrat002

@dannycranmer dannycranmer merged commit a777478 into apache:master Nov 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants