[hotfix] fix syntax errors #21263
Merged
Merged
Conversation
Collaborator
Contributor
Author
|
hi , @MartijnVisser Could you please help merge this fix ,thanks |
Contributor
Author
|
@flinkbot run azure |
MartijnVisser
approved these changes
Nov 14, 2022
Contributor
MartijnVisser
left a comment
MartijnVisser
left a comment
There was a problem hiding this comment.
@muggleChen Thank you but to be honest, the cost doesn't outweigh the benefit for these type of PRs. Yes, it's a typo and if someone works on this code, it should be fixed. But the amount of resources it costs to validate a PR like this doesn't outweigh the benefits. Please keep that in mind for the future.
Contributor
Author
|
Thanks for pointing that out, I'll keep it in mind for the future |
dchristle
pushed a commit
to dchristle/flink
that referenced
this pull request
Nov 18, 2022
akkinenivijay
pushed a commit
to krisnaru/flink
that referenced
this pull request
Feb 11, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
Fix syntax errors in org.apache.flink.streaming.api.graph.StreamGraph.
The past participle is required after "must be".
Verifying this change
This change is a trivial rework / code cleanup without any test coverage.