Skip to content

Conversation

@gaborgsomogyi
Copy link
Contributor

What is the purpose of the change

Kafka creation/deletion is an async operation. The API gives back future(s) which must be waited in order to be on the safe side. Additionally the APIs can throw exceptions while waiting to finish. In this PR I've added a more or less consistent Kafka topic creation/deletion behavior to the tests. Namely future wait to all the places where it was missing. This may or may not fix the issue (Kafka itself can be buggy) but I'm pretty sure w/o consistent topic creation/deletion API usage we're in trouble.

Brief change log

  • Wait for Kafka topic creation/deletion.
  • Add random to test topic names

Verifying this change

Existing unit tests.

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): no
  • The public API, i.e., is any changed class annotated with @Public(Evolving): no
  • The serializers: no
  • The runtime per-record code paths (performance sensitive): no
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
  • The S3 file system connector: no

Documentation

  • Does this pull request introduce a new feature? no
  • If yes, how is the feature documented? not applicable

@gaborgsomogyi
Copy link
Contributor Author

The only diff here is that there is no flink-end-to-end-tests/flink-sql-client-test/src/test/java/SqlClientITCase.java file so those changes are just not in the PR.

@gaborgsomogyi
Copy link
Contributor Author

cc @XComp @gyfora

@flinkbot
Copy link
Collaborator

flinkbot commented Nov 10, 2022

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

Copy link
Contributor

@MartijnVisser MartijnVisser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gaborgsomogyi Thanks also for this backport, LGTM

@MartijnVisser MartijnVisser self-assigned this Nov 10, 2022
@MartijnVisser MartijnVisser merged commit 9e7ebdc into apache:release-1.16 Nov 10, 2022
@gaborgsomogyi gaborgsomogyi deleted the FLINK-29914-1.16 branch September 13, 2023 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants