[hotfix][docs][table] Fix versioned table example #21308
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
leonardBang
reviewed
Nov 14, 2022
Contributor
leonardBang
left a comment
leonardBang
left a comment
There was a problem hiding this comment.
Thanks @lincoln-lil for the hotfix, could you add some description fro this PR？
Comment on lines
-157
to
+158
| +(INSERT) 11:49:00 Pounds 108 | ||
| +(INSERT) 11:45:00 Pounds 107 | ||
| +(UPDATE_AFTER) 11:49:00 Pounds 108 |
Contributor
There was a problem hiding this comment.
Why we need change here?
Contributor
Author
There was a problem hiding this comment.
it's better to add more 'update_after' lines (not just one) for better understanding
Contributor
Author
|
@leonardBang thanks for reviewing this! I've updated the description for the change. |
leonardBang
pushed a commit
that referenced
this pull request
Nov 14, 2022
leonardBang
pushed a commit
that referenced
this pull request
Nov 14, 2022
dchristle
pushed a commit
to dchristle/flink
that referenced
this pull request
Nov 18, 2022
sergeitsar
pushed a commit
to fentik/flink
that referenced
this pull request
Feb 8, 2023
sergeitsar
pushed a commit
to fentik/flink
that referenced
this pull request
Feb 8, 2023
akkinenivijay
pushed a commit
to krisnaru/flink
that referenced
this pull request
Feb 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The line "+(UPDATE_AFTER) 10:45:00 Euro 116" is redundant here, and it's better to add more 'update_after' lines (not just one) for better understanding