Skip to content

Conversation

@huwh
Copy link
Contributor

@huwh huwh commented Nov 21, 2022

What is the purpose of the change

The methods ResourceActions#notifyAllocationFailure and JobMasterGateway#notifyAllocationFailure are not used and should be removed.

Brief change log

Remove ResourceActions#notifyAllocationFailure and JobMasterGateway#notifyAllocationFailure and the related unit tests.

Verifying this change

This change is a trivial rework / code cleanup without any test coverage.

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): (no)
  • The public API, i.e., is any changed class annotated with @Public(Evolving): (no)
  • The serializers: (no)
  • The runtime per-record code paths (performance sensitive): (no)
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (no)
  • The S3 file system connector: (no)

Documentation

  • Does this pull request introduce a new feature? (no)

@flinkbot
Copy link
Collaborator

flinkbot commented Nov 21, 2022

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

@huwh huwh deleted the feat/FLINK-30084 branch November 28, 2022 12:32
akkinenivijay pushed a commit to krisnaru/flink that referenced this pull request Feb 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants