[BP-1.15][FLINK-28695][network] Fix the bug of old netty client isn't closed when netty server closes channel and no input channel#21359
Merged
pnowojski merged 1 commit intoNov 21, 2022
Conversation
Collaborator
…hen netty server closes channel and no input channel
1996fanrui
force-pushed
the
28695/close_connection_after_error_1_15
branch
from
88c1dd3 to
c2d258a
Compare
Member
Author
|
Hi @pnowojski , please help take a look in your free time, thanks. |
pnowojski
approved these changes
Nov 21, 2022
Contributor
pnowojski
left a comment
pnowojski
left a comment
There was a problem hiding this comment.
Thanks! LGTM assuming green azure.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport FLINK-28695 to 1.15.