[FLINK-27944] Input channel metric will no longer be registered multiple times#21437
Merged
pnowojski merged 2 commits intoapache:masterfrom Dec 1, 2022
reswqa:FLINK-27944-io-metrics-test
Merged
[FLINK-27944] Input channel metric will no longer be registered multiple times#21437pnowojski merged 2 commits intoapache:masterfrom reswqa:FLINK-27944-io-metrics-test
pnowojski merged 2 commits intoapache:masterfrom
reswqa:FLINK-27944-io-metrics-test
Conversation
Member
Author
|
Hi @pnowojski, Would you mind helping me to take a look this pull request when you have time? Thanks very much~ |
pnowojski
approved these changes
Dec 1, 2022
Contributor
pnowojski
left a comment
pnowojski
left a comment
There was a problem hiding this comment.
Thanks, change LGTM. However can you preserve the Xiaogang's authorship of the bug fix? I would recommend either having 3 commits here:
- the junit5 migration (as it is)
- cherry picking Xiaogang's commit
- your commit adding the test
or having the second commit having two authors.
…red multiple times Co-authored-by: xiaogang <zhouxiaogang@shizhuang-inc.com>
Member
Author
|
@pnowojski Thank you very much for reminding me. |
FMX
pushed a commit
to apache/celeborn
that referenced
this pull request
May 15, 2025
…nnelMetrics repeatedly ### What changes were proposed in this pull request? `RemoteShuffleEnvironment` should not register `InputChannelMetrics` repeatedly, which only create once in `RemoteShuffleEnvironment#createInputGates`. ### Why are the changes needed? If a task has multiple input gates, It will create as many `InputChannelMetrics` as the number of gates, so the corresponding metrics are registered repeatedly. Therefore, `RemoteShuffleEnvironment` should not register `InputChannelMetrics` repeatedly for `createInputGates`. Backport apache/flink#21437. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Manual. Closes #3257 from SteNicholas/CELEBORN-1998. Authored-by: SteNicholas <programgeek@163.com> Signed-off-by: mingji <fengmingxiao.fmx@alibaba-inc.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
If a task has multiple input gates, It will create as many
InputChannelMetricsas the number of gates, so the corresponding metrics are registered repeatedly. This pull request aimed to fix this problem.Brief change log
InputChannelMetricsinNettyShuffleEnvironment#createInputGates.Verifying this change
This change added unit test in
NettyShuffleEnvironmentTest.Does this pull request potentially affect one of the following parts:
@Public(Evolving): noDocumentation