[FLINK-30370][runtime][security] Move existing delegation token framework authentication to providers#21499
Conversation
|
cc @mbalassi |
|
@gaborgsomogyi with the externalization of the HBase connector will the |
|
@mbalassi I've mentioned the move possibility to @ferenc-csaky but seems like not yet done. From my point of view we could move it now :) |
|
@gaborgsomogyi please take a look at the CI: |
05ff332 to
73a151b
Compare
|
Just fixed it. |
| delegationTokenManager.stopTokensUpdate(); | ||
|
|
||
| assertTrue(retryExceptionThrown.get()); | ||
| assertEquals(3, startTokensUpdateCallCount.get()); |
There was a problem hiding this comment.
Here the expectation is still 3 calls:
- Manual call in line 164
- Trigger again by exception (retry)
- Trigger again by normal re-schedule
73a151b to
e1e52ab
Compare
…work authentication to providers
e1e52ab to
5693bf5
Compare
I think this should not be involved in the first round of the externalization. We try to have the first externalized connector release being the same we had in 1.16, so the connector code can be removed in 1.17 already. I will just start to port the e2e tests, which has to be done before the connector release, so there are some work to be done on that front. If there is capacity, PRs can be opened until then, I will be able to help after dealing with the e2e tests. |
|
@ferenc-csaky ok, then we can come back to this later in 1.17. At that timepoint we're going to have a relatively stable API. |
What is the purpose of the change
In order to make a generic delegation token manager all authentication specific things must be extracted. This is such a step. In this PR I've moved Kerberos authentication to the provider side.
Brief change log
Moved Kerberos authentication to the provider side.
Verifying this change
Existing unit/integration tests + manually on minikube.
Does this pull request potentially affect one of the following parts:
@Public(Evolving): noDocumentation