Skip to content

Conversation

@luoyuxia
Copy link
Contributor

@luoyuxia luoyuxia commented Dec 19, 2022

What is the purpose of the change

To wrong argument type is used when it's null literal while calling Hive's function

Brief change log

When it's null literal, consider it as WritableVoidObjectInspector instead of WritableConstantStringObjectInspector.

Verifying this change

Added test testNullLiteralAsArgument

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): (yes / no)
  • The public API, i.e., is any changed class annotated with @Public(Evolving): (yes / no)
  • The serializers: (yes / no / don't know)
  • The runtime per-record code paths (performance sensitive): (yes / no / don't know)
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (yes / no / don't know)
  • The S3 file system connector: (yes / no / don't know)

Documentation

  • Does this pull request introduce a new feature? (yes / no)
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)

@flinkbot
Copy link
Collaborator

flinkbot commented Dec 19, 2022

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

@luoyuxia luoyuxia changed the title fix use wrong argument type is used when call Hive's function [FLINK-30452][hive] fix use wrong argument type is used when call Hive's function Dec 26, 2022
@beyond1920 beyond1920 changed the title [FLINK-30452][hive] fix use wrong argument type is used when call Hive's function [FLINK-30452][hive] fix use wrong argument type of null literal is used when call Hive's function Dec 27, 2022
Copy link
Contributor

@beyond1920 beyond1920 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for contribution.
I would merge asap.

chucheng92 pushed a commit to chucheng92/flink that referenced this pull request Feb 3, 2023
akkinenivijay pushed a commit to krisnaru/flink that referenced this pull request Feb 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants