Skip to content

Conversation

@link3280
Copy link
Contributor

@link3280 link3280 commented Jan 2, 2023

What is the purpose of the change

Currently, the stop-job operation produces some verbose error msg and doesn't handle exceptions in stop-without-savepoint gracefully.

This PR fixes the problem.

Brief change log

  • Wrap simple cancel with try-catch.
  • Wait for simple cancel Acknowledge before returning 'OK'.
  • Simplify exception message for stop job operations.

Verifying this change

Please make sure both new and modified tests in this PR follows the conventions defined in our code quality guide: https://flink.apache.org/contributing/code-style-and-quality-common.html#testing

This change is a trivial rework / code cleanup without any test coverage.

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): no
  • The public API, i.e., is any changed class annotated with @Public(Evolving): no
  • The serializers: no
  • The runtime per-record code paths (performance sensitive): no
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
  • The S3 file system connector: no

Documentation

  • Does this pull request introduce a new feature? no
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)

@flinkbot
Copy link
Collaborator

flinkbot commented Jan 2, 2023

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

@link3280
Copy link
Contributor Author

link3280 commented Jan 3, 2023

@flinkbot run azure

@link3280
Copy link
Contributor Author

link3280 commented Jan 3, 2023

Please kindly take a look @fsk119

Copy link
Member

@fsk119 fsk119 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your update.

@link3280
Copy link
Contributor Author

CI ran into https://issues.apache.org/jira/browse/FLINK-30328. Re-run CI.

@link3280
Copy link
Contributor Author

@flinkbot run azure

@link3280
Copy link
Contributor Author

@fsk119 CI turned green. Please kindly take a look at your convenience.

@link3280
Copy link
Contributor Author

ping @fsk119 . It should be a quick one :)

@link3280
Copy link
Contributor Author

ping @fsk119

@link3280 link3280 force-pushed the FLINK-30538 branch 2 times, most recently from f0aa98f to 36c9610 Compare January 30, 2023 09:57
Copy link
Member

@fsk119 fsk119 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fsk119 fsk119 merged commit d657395 into apache:master Feb 1, 2023
akkinenivijay pushed a commit to krisnaru/flink that referenced this pull request Feb 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants