-
Notifications
You must be signed in to change notification settings - Fork 13.8k
[FLINK-30538][SQL gateway/client] Improve error handling of stop job operation #21581
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@flinkbot run azure |
|
Please kindly take a look @fsk119 |
fsk119
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your update.
...ateway/src/main/java/org/apache/flink/table/gateway/service/operation/OperationExecutor.java
Outdated
Show resolved
Hide resolved
|
CI ran into https://issues.apache.org/jira/browse/FLINK-30328. Re-run CI. |
|
@flinkbot run azure |
|
@fsk119 CI turned green. Please kindly take a look at your convenience. |
|
ping @fsk119 . It should be a quick one :) |
|
ping @fsk119 |
f0aa98f to
36c9610
Compare
fsk119
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…tion when meeet error This closes apache#21581
What is the purpose of the change
Currently, the stop-job operation produces some verbose error msg and doesn't handle exceptions in stop-without-savepoint gracefully.
This PR fixes the problem.
Brief change log
Verifying this change
Please make sure both new and modified tests in this PR follows the conventions defined in our code quality guide: https://flink.apache.org/contributing/code-style-and-quality-common.html#testing
This change is a trivial rework / code cleanup without any test coverage.
Does this pull request potentially affect one of the following parts:
@Public(Evolving): noDocumentation