[FLINK-29884][test] Fix flaky test SortMergeResultPartitionTest.testRelease #21707
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…elease. If view has read all buffers before result partition release, it will not release itself directly. This may cause the test to timeout under race condition.
Collaborator
Contributor
|
@reswqa Thanks for the fix. LGTM. Failure unrelated, Merging. |
chucheng92
pushed a commit
to chucheng92/flink
that referenced
this pull request
Feb 3, 2023
…elease If view has read all buffers before result partition release, it will not release itself directly. This may cause the test to timeout under race condition. This closes apache#21707.
akkinenivijay
pushed a commit
to krisnaru/flink
that referenced
this pull request
Feb 11, 2023
…elease If view has read all buffers before result partition release, it will not release itself directly. This may cause the test to timeout under race condition. This closes apache#21707.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
Fix flaky test
SortMergeResultPartitionTest#testReleaseBrief change log
Verifying this change
This change is a fix for flaky test.
Does this pull request potentially affect one of the following parts:
@Public(Evolving): noDocumentation