Skip to content

Conversation

@TJX2014
Copy link

@TJX2014 TJX2014 commented Jan 26, 2023

What is the purpose of the change

Fix test case broken in win os.

Brief change log

Change "file://" to LocalFileSystem.getLocalFsURI.toString.

Verifying this change

org.apache.flink.table.planner.runtime.stream.sql.WindowAggregateITCase case work correctly in win os.

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): (yes / no)
  • The public API, i.e., is any changed class annotated with @Public(Evolving): (yes / no)
  • The serializers: (yes / no / don't know)
  • The runtime per-record code paths (performance sensitive): (yes / no / don't know)
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (yes / no / don't know)
  • The S3 file system connector: (yes / no / don't know)

Documentation

  • Does this pull request introduce a new feature? (yes / no)
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)

@flinkbot
Copy link
Collaborator

flinkbot commented Jan 26, 2023

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

Copy link
Member

@healchow healchow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@TJX2014 TJX2014 force-pushed the fix-path-in-win-not-correct branch from 2897658 to c3f9f10 Compare January 28, 2023 06:21
@TJX2014
Copy link
Author

TJX2014 commented Jan 29, 2023

Hi @healchow @zentol , could you please review and merge this pr? the ci has passed.

@zentol
Copy link
Contributor

zentol commented Feb 10, 2023

We no longer account for developing Flink on Windows. Only unix environments are supported.

@zentol zentol closed this Feb 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants