Skip to content

[FLINK-30624][runtime] Introduce a new HeapPriorityQueue for StatusWatermarkValve to avoid affecting the performance of memory state backend.#21779

Closed
wanglijie95 wants to merge 1 commit into
apache:masterfrom
wanglijie95:FLINK-30624
Closed

Conversation

@wanglijie95
Copy link
Copy Markdown
Contributor

What is the purpose of the change

Fix the performance regression described in FLINK-30624.

before this fix:
Benchmark                                  (stateBackend)   Mode  Cnt     Score    Error   Units
MemoryStateBackendBenchmark.stateBackends          MEMORY  thrpt   30  3936.158 ± 65.696  ops/ms
MemoryStateBackendBenchmark.stateBackends              FS  thrpt   30  3963.934 ± 64.942  ops/ms
MemoryStateBackendBenchmark.stateBackends        FS_ASYNC  thrpt   30  3930.955 ± 68.809  ops/ms`

after this fix:
Benchmark                                  (stateBackend)   Mode  Cnt     Score    Error   Units
MemoryStateBackendBenchmark.stateBackends          MEMORY  thrpt   30  4151.066 ± 80.526  ops/ms
MemoryStateBackendBenchmark.stateBackends              FS  thrpt   30  4143.619 ± 65.212  ops/ms
MemoryStateBackendBenchmark.stateBackends        FS_ASYNC  thrpt   30  4161.912 ± 44.701  ops/ms

Verifying this change

This change is already covered by existing tests

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): (no)
  • The public API, i.e., is any changed class annotated with @Public(Evolving): (no)
  • The serializers: (no)
  • The runtime per-record code paths (performance sensitive): (no)
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (no)
  • The S3 file system connector: (no)

Documentation

  • Does this pull request introduce a new feature? (no)
  • If yes, how is the feature documented? (not applicable)

@wanglijie95 wanglijie95 requested a review from zhuzhurk January 30, 2023 00:45
@flinkbot
Copy link
Copy Markdown
Collaborator

flinkbot commented Jan 30, 2023

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

…termarkValve to avoid affecting the performance of memory state backend.
@wanglijie95
Copy link
Copy Markdown
Contributor Author

@flinkbot run azure

Copy link
Copy Markdown
Contributor

@zhuzhurk zhuzhurk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@wanglijie95
Copy link
Copy Markdown
Contributor Author

@flinkbot run azure

@zhuzhurk zhuzhurk closed this in 21e844b Jan 30, 2023
@wanglijie95 wanglijie95 deleted the FLINK-30624 branch January 31, 2023 01:05
akkinenivijay pushed a commit to krisnaru/flink that referenced this pull request Feb 11, 2023
…termarkValve to avoid affecting the performance of memory state backend.

This closes apache#21779.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants