-
Notifications
You must be signed in to change notification settings - Fork 13.9k
[FLINK-30823][runtime] Enable speculative execution for typical built-in sinks #21796
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
...-files/src/test/java/org/apache/flink/connector/file/table/PartitionTempFileManagerTest.java
Outdated
Show resolved
Hide resolved
...nector-files/src/main/java/org/apache/flink/connector/file/table/FileSystemOutputFormat.java
Show resolved
Hide resolved
...ctors/flink-connector-files/src/main/java/org/apache/flink/connector/file/sink/FileSink.java
Show resolved
Hide resolved
...ctor-files/src/main/java/org/apache/flink/connector/file/table/PartitionTempFileManager.java
Show resolved
Hide resolved
|
@zhuzhurk How about opening another ticket for the it case? It might be a litter heavy for this pr. We can build a common it case framework to verify speculative execution for different connectors. |
Sounds good to me. |
zhuzhurk
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
5979295 to
c303d50
Compare
…putFormat This closes apache#21796.
What is the purpose of the change
This pull request enables speculative execution for some of typical built-in sinks
Brief change log
DiscardingSinkPrintSinkFunctionPrintSinkFileSinkFileSystemOutputFormatVerifying this change
This change added tests:
PartitionTempFileManagerTestDoes this pull request potentially affect one of the following parts:
@Public(Evolving): (no)Documentation