Skip to content

Conversation

@ifndef-SleePy
Copy link
Contributor

What is the purpose of the change

This pull request enables speculative execution for some of typical built-in sinks

Brief change log

  • Enable speculative execution for DiscardingSink
  • Enable speculative execution for PrintSinkFunction
  • Enable speculative execution for PrintSink
  • Enable speculative execution for FileSink
  • Enable speculative execution for FileSystemOutputFormat

Verifying this change

This change added tests:

  • Added test case in PartitionTempFileManagerTest

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): (no)
  • The public API, i.e., is any changed class annotated with @Public(Evolving): (no)
  • The serializers: (no)
  • The runtime per-record code paths (performance sensitive): (no)
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (no)
  • The S3 file system connector: (no)

Documentation

  • Does this pull request introduce a new feature? (no)
  • If yes, how is the feature documented? (not applicable)

@flinkbot
Copy link
Collaborator

flinkbot commented Jan 31, 2023

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

@ifndef-SleePy
Copy link
Contributor Author

@zhuzhurk How about opening another ticket for the it case? It might be a litter heavy for this pr. We can build a common it case framework to verify speculative execution for different connectors.

@zhuzhurk
Copy link
Contributor

@zhuzhurk How about opening another ticket for the it case? It might be a litter heavy for this pr. We can build a common it case framework to verify speculative execution for different connectors.

Sounds good to me.

Copy link
Contributor

@zhuzhurk zhuzhurk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@zhuzhurk zhuzhurk closed this in 1420ee7 Jan 31, 2023
akkinenivijay pushed a commit to krisnaru/flink that referenced this pull request Feb 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants