[FLINK-30868][table-api] Fix to use origin LongSerializer for seriali… #21827
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
lincoln-lil
reviewed
Feb 2, 2023
Contributor
lincoln-lil
left a comment
lincoln-lil
left a comment
There was a problem hiding this comment.
@fsk119 It's greate we can reserve the compatibility for 1.17 by this patch! Only some comments for the testing.
flink-table/flink-table-common/src/main/java/org/apache/flink/table/utils/TableSchemaUtils.java
Show resolved
Hide resolved
| @SuppressWarnings("unchecked") | ||
| public TypeSerializer<Timestamp> createSerializer(ExecutionConfig executionConfig) { | ||
| return (TypeSerializer) LocalDateTimeSerializer.INSTANCE; | ||
| return (TypeSerializer) LongSerializer.INSTANCE; |
Contributor
There was a problem hiding this comment.
Any tests releated to this change?
Member
Author
There was a problem hiding this comment.
They modify the TimeIndicatorTypeInfo is because it will break the test FunctionITCase#testAggregateFunction. Now I revert the change in the TimeIndicatorTypeInfo and make sure the test still passes. So I think the origin test is enough.
lincoln-lil
approved these changes
Feb 2, 2023
| @SuppressWarnings("unchecked") | ||
| public TypeSerializer<Timestamp> createSerializer(ExecutionConfig executionConfig) { | ||
| return (TypeSerializer) LocalDateTimeSerializer.INSTANCE; | ||
| return (TypeSerializer) LongSerializer.INSTANCE; |
…zation in the TimeIndicatorTypeInfo
akkinenivijay
pushed a commit
to krisnaru/flink
that referenced
this pull request
Feb 11, 2023
…zation in the TimeIndicatorTypeInfo (apache#21827)
mohsenrezaeithe
pushed a commit
to mohsenrezaeithe/flink
that referenced
this pull request
Feb 21, 2023
…zation in the TimeIndicatorTypeInfo (apache#21827)
Tan-JiaLiang
pushed a commit
to Tan-JiaLiang/flink
that referenced
this pull request
Mar 4, 2024
…zation in the TimeIndicatorTypeInfo (apache#21827) (cherry picked from commit 48a2e5a)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…zation in the TimeIndicatorTypeInfo
What is the purpose of the change
Revert the API change in the #21182 to use the origin LongSerializer.
Does this pull request potentially affect one of the following parts:
@Public(Evolving): (yes / no)Documentation