-
Notifications
You must be signed in to change notification settings - Fork 13.8k
[FLINK-31035] add warn info to user when NoNodeException happend #21914
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@reswqa have a review plz,thanks |
|
@xuzifu666 Thanks for creating this. Could you explain why it is necessary to print warn-level logs here? Personally, this only happens when the |
we offten occur zk leader change when zxid over it's range, get the message can tell us in time. |
flink-runtime/src/main/java/org/apache/flink/runtime/zookeeper/ZooKeeperStateHandleStore.java
Outdated
Show resolved
Hide resolved
…/ZooKeeperStateHandleStore.java Co-authored-by: Roman <khachatryan.roman@gmail.com>
|
@rkhachatryan ok,get |
|
@rkhachatryan hi,this pr can be merged? this message is need where we occur zk leader change to resolve problem |
|
Hi @xuzifu666, |
Update flink-runtime/src/main/java/org/apache/flink/runtime/zookeeper/ZooKeeperStateHandleStore.java Co-authored-by: Roman <khachatryan.roman@gmail.com>
@rkhachatryan ok,thanks,i squash these commits,and commit with the comment which is according to guide,can merge now? |
|
IMO, we should only have one commit like |
|
As pointed out by @reswqa , there are build failures related to formatting, could you address them @xuzifu666 ? |
|
cc @reswqa @rkhachatryan hi,this pr would closed,and move it to #22980 |
What is the purpose of the change
(For example: This pull request makes task deployment go through the blob server, rather than through RPC. That way we avoid re-transferring them on each deployment (during recovery).)
Brief change log
(for example:)
Verifying this change
Please make sure both new and modified tests in this PR follows the conventions defined in our code quality guide: https://flink.apache.org/contributing/code-style-and-quality-common.html#testing
(Please pick either of the following options)
This change is a trivial rework / code cleanup without any test coverage.
(or)
This change is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(example:)
Does this pull request potentially affect one of the following parts:
@Public(Evolving): (yes / no)Documentation