Skip to content

Conversation

@xuzifu666
Copy link
Member

What is the purpose of the change

(For example: This pull request makes task deployment go through the blob server, rather than through RPC. That way we avoid re-transferring them on each deployment (during recovery).)

Brief change log

(for example:)

  • The TaskInfo is stored in the blob store on job creation time as a persistent artifact
  • Deployments RPC transmits only the blob storage reference
  • TaskManagers retrieve the TaskInfo from the blob cache

Verifying this change

Please make sure both new and modified tests in this PR follows the conventions defined in our code quality guide: https://flink.apache.org/contributing/code-style-and-quality-common.html#testing

(Please pick either of the following options)

This change is a trivial rework / code cleanup without any test coverage.

(or)

This change is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(example:)

  • Added integration tests for end-to-end deployment with large payloads (100MB)
  • Extended integration test for recovery after master (JobManager) failure
  • Added test that validates that TaskInfo is transferred only once across recoveries
  • Manually verified the change by running a 4 node cluster with 2 JobManagers and 4 TaskManagers, a stateful streaming program, and killing one JobManager and two TaskManagers during the execution, verifying that recovery happens correctly.

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): (yes / no)
  • The public API, i.e., is any changed class annotated with @Public(Evolving): (yes / no)
  • The serializers: (yes / no / don't know)
  • The runtime per-record code paths (performance sensitive): (yes / no / don't know)
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (yes / no / don't know)
  • The S3 file system connector: (yes / no / don't know)

Documentation

  • Does this pull request introduce a new feature? (yes / no)
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)

@xuzifu666 xuzifu666 changed the title add warn info to user when NoNodeException happend [hotfix] add warn info to user when NoNodeException happend Feb 13, 2023
@xuzifu666
Copy link
Member Author

@reswqa have a review plz,thanks

@flinkbot
Copy link
Collaborator

flinkbot commented Feb 13, 2023

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

@reswqa
Copy link
Member

reswqa commented Feb 13, 2023

@xuzifu666 Thanks for creating this. Could you explain why it is necessary to print warn-level logs here? Personally, this only happens when the ZNode is modified concurrently. The framework will retry itself, and printing the log will make users feel confused.

@xuzifu666
Copy link
Member Author

@xuzifu666 Thanks for creating this. Could you explain why it is necessary to print warn-level logs here? Personally, this only happens when the ZNode is modified concurrently. The framework will retry itself, and printing the log will make users feel confused.

we offten occur zk leader change when zxid over it's range, get the message can tell us in time.

@xuzifu666 xuzifu666 changed the title [hotfix] add warn info to user when NoNodeException happend [FLINK-31035] add warn info to user when NoNodeException happend Feb 13, 2023
@xuzifu666
Copy link
Member Author

@rkhachatryan

@xuzifu666
Copy link
Member Author

@zentol

…/ZooKeeperStateHandleStore.java

Co-authored-by: Roman <khachatryan.roman@gmail.com>
@xuzifu666
Copy link
Member Author

@rkhachatryan ok,get

@xuzifu666
Copy link
Member Author

@rkhachatryan hi,this pr can be merged? this message is need where we occur zk leader change to resolve problem

@rkhachatryan
Copy link
Contributor

Hi @xuzifu666,
could you please squash the commits into one and format the commit message according to Flink guide (similar to the PR title)?

xuzifu666 and others added 2 commits March 6, 2023 19:31
Update flink-runtime/src/main/java/org/apache/flink/runtime/zookeeper/ZooKeeperStateHandleStore.java

Co-authored-by: Roman <khachatryan.roman@gmail.com>
@xuzifu666
Copy link
Member Author

xuzifu666 commented Mar 6, 2023

Hi @xuzifu666, could you please squash the commits into one and format the commit message according to Flink guide (similar to the PR title)?

@rkhachatryan ok,thanks,i squash these commits,and commit with the comment which is according to guide,can merge now?

@reswqa
Copy link
Member

reswqa commented Mar 6, 2023

IMO, we should only have one commit like [FLINK-31035][runtime] Log debug message when NoNodeException thrown while getAllHandles. And the CI is failed as compile problems, you should fix this first.

@rkhachatryan
Copy link
Contributor

As pointed out by @reswqa , there are build failures related to formatting, could you address them @xuzifu666 ?
And there are still several commits in the history, could you please merge everything into one?

@xuzifu666
Copy link
Member Author

cc @reswqa @rkhachatryan hi,this pr would closed,and move it to #22980

@xuzifu666 xuzifu666 closed this Jul 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants