Skip to content

Conversation

@chucheng92
Copy link
Member

What is the purpose of the change

SplitReader doesn't extend AutoCloseable but implements close method. We need to let it extends AutoCloseable which could enable us to utilize Java's try close feature.

Brief change log

Let SplitReader interface extends AutoCloseable.

Verifying this change

Because SplitReader#close override AutoCloseable#close with same signature and behavior. It has no effect on connector implementations. It can be tested by current ci test cases.

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): no
  • The public API, i.e., is any changed class annotated with @Public(Evolving): yes
  • The serializers: no
  • The runtime per-record code paths (performance sensitive): no
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
  • The S3 file system connector: no

Documentation

  • Does this pull request introduce a new feature? no
  • If yes, how is the feature documented? not applicable

@chucheng92 chucheng92 changed the title [FLINK-31015][connectors/common] Fix SplitReader doesn't extend AutoCloseable but implements close method [FLINK-31015][connectors/common] Fix SplitReader doesn't extends AutoCloseable but implements close method Feb 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants