Skip to content

Conversation

@Samrat002
Copy link
Contributor

@Samrat002 Samrat002 commented Mar 20, 2023

What is the purpose of the change

Add support for new cli option -py.pythonpath. this config will point to path on the instances where python is installed.

Verifying changes

covered in UT

Brief change log

  • -pypythonPath for command line option.

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): (yes / no) no
  • The public API, i.e., is any changed class annotated with @Public(Evolving): (yes / no) yes
  • The serializers: (yes / no / don't know) no
  • The runtime per-record code paths (performance sensitive): (yes / no / don't know) no
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (yes / no / don't know) no
  • The S3 file system connector: (yes / no / don't know) no

Documentation

  • Does this pull request introduce a new feature? (yes / no) no
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented) no

@flinkbot
Copy link
Collaborator

flinkbot commented Mar 20, 2023

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

Copy link
Contributor

@dannycranmer dannycranmer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, please add unit tests. I see this area of the code is not well tested, but can we at least update PythonDependencyUtilsTest please

@Samrat002 Samrat002 force-pushed the FLINK-31214 branch 2 times, most recently from 403e254 to cf9e1f7 Compare April 3, 2023 19:01
@Samrat002
Copy link
Contributor Author

thanks for reviewing the changes. i have made changes as per previous review comments. can you please review whenever time .
@dannycranmer

Copy link
Contributor

@dannycranmer dannycranmer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @Samrat002

@dannycranmer dannycranmer merged commit f8b0834 into apache:master Apr 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants