Skip to content

[FLINK-31541][UI] encode request params to support special characters metrics name. #22243

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
huwh wants to merge 1 commit into from
Closed

[FLINK-31541][UI] encode request params to support special characters metrics name. #22243

huwh wants to merge 1 commit into from

Conversation

@huwh
Copy link
Contributor

@huwh huwh commented Mar 23, 2023 •
edited
Loading

What is the purpose of the change

User could set operator name with some special characters, such as '%' and '['. This cause request failed when try to get metrics of this operator in WEB UI.

Brief change log

  • *move the request parameters from url to option:params to let http client encode the special characters *

Verifying this change

  • Run web ui with special operator name, metrics could be retrieved successfully.
  • image
  • image

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): (no)
  • The public API, i.e., is any changed class annotated with @Public(Evolving): (no)
  • The serializers: (no)
  • The runtime per-record code paths (performance sensitive): (no)
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (no)
  • The S3 file system connector: (no)

Documentation

  • Does this pull request introduce a new feature? (no)

@huwh huwh changed the title [FLINK-31541] encode request params to support special characters metrics name. [FLINK-31541][UI] encode request params to support special characters metrics name. Mar 23, 2023
@flinkbot
Copy link
Collaborator

flinkbot commented Mar 23, 2023 •
edited
Loading

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

@reswqa reswqa requested a review from yangjunhan March 23, 2023 10:44
@reswqa
Copy link
Member

reswqa commented Mar 23, 2023

@yangjunhan Would you mind taking a look at this?

yangjunhan
yangjunhan approved these changes Mar 28, 2023
View reviewed changes
Copy link
Contributor

@yangjunhan yangjunhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@reswqa reswqa closed this in de27786 Mar 28, 2023
reswqa
reswqa reviewed Mar 28, 2023
View reviewed changes
Copy link
Member

@reswqa reswqa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, merged.

huwh added a commit to huwh/flink that referenced this pull request Mar 28, 2023
@huwh
[FLINK-31541][ui] encode request params to support special characters…
1e60c47 
… in metrics name.

This closes apache#22243

(cherry picked from commit de27786)
@huwh huwh deleted the FLINK-31541 branch March 29, 2023 06:01
reswqa pushed a commit that referenced this pull request Mar 29, 2023
@huwh @reswqa
[FLINK-31541][ui] encode request params to support special characters…
1e0b58a 
… in metrics name.

This closes #22243

(cherry picked from commit de27786)
RocMarshal pushed a commit to RocMarshal/flink that referenced this pull request May 9, 2024
@huwh
[FLINK-31541][ui] encode request params to support special characters…
05f1299 
… in metrics name.

This closes apache#22243

(cherry picked from commit de27786)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@reswqa reswqa reswqa left review comments

@yangjunhan yangjunhan yangjunhan approved these changes

Assignees

No one assigned

Labels

component=Runtime/Metrics component=Runtime/WebFrontend

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@huwh @flinkbot @reswqa @yangjunhan