Skip to content

Conversation

@huwh
Copy link
Contributor

@huwh huwh commented Mar 26, 2023

What is the purpose of the change

The path of cached files should quote by either single (') or double quotes ("), not the back quote (`)

The path will parsed as '`file' when using back quote.
image

Brief change log

  • Fix examples of pipeline.cached-files in documents

Verifying this change

This change is a trivial rework / code cleanup without any test coverage.

The path of cached files should quote by either single (') or double quotes ("), not the back quote (`)
@flinkbot
Copy link
Collaborator

flinkbot commented Mar 26, 2023

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

@huwh
Copy link
Contributor Author

huwh commented Mar 27, 2023

Hi, @reswqa Could you help review this hotfix?

Copy link
Member

@reswqa reswqa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @huwh, LGTM.

@reswqa reswqa merged commit 04dbdc0 into apache:master Mar 27, 2023
@huwh huwh deleted the fixDocs branch March 29, 2023 06:03
xiangyuf pushed a commit to xiangyuf/flink that referenced this pull request Nov 16, 2023
apache#22273)

The path of cached files should quote by either single (') or double quotes ("), not the back quote (`)

(cherry picked from commit 04dbdc0)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants