Skip to content

Conversation

@sdmoralesma
Copy link
Contributor

What is the purpose of the change

Increasing the usability of Flink with JDK 17: sun.net.util.IPAddressUtil is not exported by the JDK, i.e. --add-opens configuration is needed for making use of it.

Brief change log

  • Replace usage of sun.net.util.IPAddressUtil with com.google.common.net.InetAddresses in production and testing code.
  • Complement coverage of unit test case when host is null.

Verifying this change

This change is already covered by existing tests, such as NetUtilsTest and TaskManagerRunnerConfigurationTest.

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): no
  • The public API, i.e., is any changed class annotated with @Public(Evolving): no
  • The serializers: no
  • The runtime per-record code paths (performance sensitive): no
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
  • The S3 file system connector: no

Documentation

  • Does this pull request introduce a new feature? no
  • If yes, how is the feature documented? not applicable

@flinkbot
Copy link
Collaborator

flinkbot commented Apr 23, 2023

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

@zentol zentol self-assigned this Apr 24, 2023
@zentol zentol merged commit c02fcfb into apache:master Apr 24, 2023
@sdmoralesma sdmoralesma deleted the FLINK-30478 branch April 24, 2023 12:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants