-
Notifications
You must be signed in to change notification settings - Fork 13.9k
[FLINK-32060][test] Migrate subclasses of BatchAbstractTestBase in table and other modules to JUnit5 #22574
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
92da2ae to
4aec8a9
Compare
snuyanzin
reviewed
May 15, 2023
flink-formats/flink-avro/src/test/java/org/apache/flink/formats/avro/AvroFilesystemITCase.java
Outdated
Show resolved
Hide resolved
snuyanzin
reviewed
May 15, 2023
...ts/flink-parquet/src/test/java/org/apache/flink/formats/parquet/ParquetFileSystemITCase.java
Outdated
Show resolved
Hide resolved
snuyanzin
reviewed
May 15, 2023
flink-formats/flink-orc/src/test/java/org/apache/flink/orc/OrcFileSystemITCase.java
Show resolved
Hide resolved
snuyanzin
reviewed
May 15, 2023
...ts/flink-parquet/src/test/java/org/apache/flink/formats/parquet/ParquetFileSystemITCase.java
Show resolved
Hide resolved
reswqa
commented
May 15, 2023
...rc/test/scala/org/apache/flink/table/planner/runtime/batch/sql/FileSystemTestCsvITCase.scala
Show resolved
Hide resolved
snuyanzin
reviewed
May 15, 2023
flink-formats/flink-orc/src/test/java/org/apache/flink/orc/OrcFileSystemITCase.java
Outdated
Show resolved
Hide resolved
snuyanzin
reviewed
May 15, 2023
...est/scala/org/apache/flink/table/planner/runtime/stream/sql/StreamFileSystemITCaseBase.scala
Show resolved
Hide resolved
Contributor
|
I checked that now number of tests before the change is equal to number of tests after per changed class |
snuyanzin
approved these changes
May 15, 2023
Member
Author
|
Thanks @snuyanzin very much for your patient review 👍 . Without you, I didn't even realize that the number of tests wouldn't be right (my mistake) 🙇 |
…ble and other modules to JUnit5
Member
Author
|
Rebased all fix-up commits, will be merged after AZP green. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
Migrate subclasses of BatchAbstractTestBase in table and other modules to JUnit5
Brief change log
Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
Does this pull request potentially affect one of the following parts:
@Public(Evolving): noDocumentation