Skip to content

Conversation

@reswqa
Copy link
Member

@reswqa reswqa commented May 12, 2023

What is the purpose of the change

Migrate subclasses of BatchAbstractTestBase in table and other modules to JUnit5

Brief change log

  • Migrate subclasses of BatchAbstractTestBase in table and other modules to JUnit5

Verifying this change

This change is a trivial rework / code cleanup without any test coverage.

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): no
  • The public API, i.e., is any changed class annotated with @Public(Evolving): no
  • The serializers: no
  • The runtime per-record code paths (performance sensitive): no
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
  • The S3 file system connector: no

Documentation

  • Does this pull request introduce a new feature? no

@flinkbot
Copy link
Collaborator

flinkbot commented May 12, 2023

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

@reswqa reswqa force-pushed the FLINK-32060 branch 2 times, most recently from 92da2ae to 4aec8a9 Compare May 15, 2023 08:09
@snuyanzin
Copy link
Contributor

I checked that now number of tests before the change is equal to number of tests after per changed class
no more findings from my side
lgtm

@reswqa
Copy link
Member Author

reswqa commented May 15, 2023

Thanks @snuyanzin very much for your patient review 👍 . Without you, I didn't even realize that the number of tests wouldn't be right (my mistake) 🙇

@reswqa
Copy link
Member Author

reswqa commented May 16, 2023

Rebased all fix-up commits, will be merged after AZP green.

@reswqa reswqa merged commit ce286c9 into apache:master May 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants