[FLINK-32154][build] Setup checkstyle rules to forbid mockito/powermock #22619
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
zentol
force-pushed
the
31954
branch
2 times, most recently
from
f9704d4 to
6f68122
Compare
reswqa
reviewed
May 24, 2023
Member
reswqa
left a comment
reswqa
left a comment
There was a problem hiding this comment.
I manually tested this by introducing some imports of mockito/powermock, everything looked as expected.
reswqa
approved these changes
May 24, 2023
Member
reswqa
left a comment
reswqa
left a comment
There was a problem hiding this comment.
Thanks for the quick update, +1 for this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #22616/#22617.
Sets up new illegal import rules, and adds suppressions for existing mockito/powermock usages.