[FLINK-31894][runtime] ExceptionHistory and REST API failure label integration#22643
Merged
dmvk merged 1 commit intoapache:masterfrom Jun 2, 2023
Merged
[FLINK-31894][runtime] ExceptionHistory and REST API failure label integration#22643dmvk merged 1 commit intoapache:masterfrom
dmvk merged 1 commit intoapache:masterfrom
Conversation
Collaborator
pgaref
force-pushed
the
FLINK-31894
branch
3 times, most recently
from
1293958 to
4d44543
Compare
Member
|
The biggest question I have is whether the filters are supposed to be ANDed or ORed 🤔 Right now if a single filter matches we keep the exception. |
dmvk
reviewed
May 31, 2023
Contributor
Author
Thanks @dmvk !
PTAL |
dmvk
approved these changes
Jun 1, 2023
Member
dmvk
left a comment
dmvk
left a comment
There was a problem hiding this comment.
👍 good job; let's just get rid of the separate FailureLabel class as discussed offline
…tegration * Introduce FailureLabel class as a KV string container * Add support for failure labels on JobExceptionsInfoWithHistory * Extend JobExceptionsHandler to support `failureLabelFilter` * Extend JobExceptionsHandlerTest to validate functionality
Contributor
Author
Thanks much @dmvk ! Updated :) |
dmvk
approved these changes
Jun 2, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://issues.apache.org/jira/browse/FLINK-31894
failureLabelFilter