Skip to content

[FLINK-32249][table-planner] Use proper toString conversion when constructing column comments for CatalogTable#22715

Merged
lincoln-lil merged 1 commit intoapache:release-1.17from
lincoln-lil:FLINK-32249
Jun 6, 2023
Merged

[FLINK-32249][table-planner] Use proper toString conversion when constructing column comments for CatalogTable#22715
lincoln-lil merged 1 commit intoapache:release-1.17from
lincoln-lil:FLINK-32249

Conversation

@lincoln-lil
Copy link
Contributor

What is the purpose of the change

The current SqlCreateTableConverter does not use the correct toString method when constructing column comments for CatalogTable, which may cause sql-client users and catalog implementers to encounter problems with Chinese characters in column comments not being displayed as expected.

Brief change log

update the toString logic for column comments in SqlCreateTableConverter

Verifying this change

Add Chinese characters in test cases of SqlDdlToOperationConverterTest

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): (no)
  • The public API, i.e., is any changed class annotated with @public(Evolving): (no)
  • The serializers: (no )
  • The runtime per-record code paths (performance sensitive): (no)
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (no)
  • The S3 file system connector: (no)

Documentation

  • Does this pull request introduce a new feature? (no)

@flinkbot
Copy link
Collaborator

flinkbot commented Jun 5, 2023

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

Copy link
Contributor

@Aitozi Aitozi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@libenchao libenchao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@lincoln-lil lincoln-lil merged commit 7c2631b into apache:release-1.17 Jun 6, 2023
RocMarshal pushed a commit to RocMarshal/flink that referenced this pull request May 9, 2024
…tructing column comments for CatalogTable

This closes apache#22715
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants