[FLINK-32249][table-planner] Use proper toString conversion when constructing column comments for CatalogTable#22715
Merged
lincoln-lil merged 1 commit intoapache:release-1.17from Jun 6, 2023
Conversation
…tructing column comments for CatalogTable
Collaborator
RocMarshal
pushed a commit
to RocMarshal/flink
that referenced
this pull request
May 9, 2024
…tructing column comments for CatalogTable This closes apache#22715
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
The current
SqlCreateTableConverterdoes not use the correct toString method when constructing column comments forCatalogTable, which may cause sql-client users and catalog implementers to encounter problems with Chinese characters in column comments not being displayed as expected.Brief change log
update the toString logic for column comments in
SqlCreateTableConverterVerifying this change
Add Chinese characters in test cases of
SqlDdlToOperationConverterTestDoes this pull request potentially affect one of the following parts:
Documentation