Skip to content

[FLINK-31642][network] Introduce the MemoryTierConsumerAgent #22733

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
reswqa merged 3 commits into from
Jun 20, 2023
Merged

[FLINK-31642][network] Introduce the MemoryTierConsumerAgent #22733

reswqa merged 3 commits into from
Jun 20, 2023

Conversation

@WencongLiu
Copy link
Contributor

@WencongLiu WencongLiu commented Jun 8, 2023 •
edited
Loading

What is the purpose of the change

Introduce the MemoryTierConsumerAgent

  1. Implement the MemoryTierConsumerAgent
  2. Introduce the MemoryTierConsumerAgent to TieredStorageConsumerClient
  3. Enable NettyConnectionReader to notify upstream required segment id

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): (no)
  • The public API, i.e., is any changed class annotated with @Public(Evolving): (no)
  • The serializers: (no)
  • The runtime per-record code paths (performance sensitive): (no)
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (no)
  • The S3 file system connector: (no)

Documentation

  • Does this pull request introduce a new feature? (yes)
  • If yes, how is the feature documented? (not documented)

@flinkbot
Copy link
Collaborator

flinkbot commented Jun 8, 2023 •
edited
Loading

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

@WencongLiu WencongLiu force-pushed the dev_FLINK_31642 branch 4 times, most recently from a140e71 to ba06975 Compare June 12, 2023 12:45
@WencongLiu WencongLiu force-pushed the dev_FLINK_31642 branch 2 times, most recently from 1b8c20d to 1ce2cc2 Compare June 14, 2023 03:47
@WencongLiu WencongLiu force-pushed the dev_FLINK_31642 branch 5 times, most recently from 4ab8b65 to 4b86233 Compare June 16, 2023 04:35
xintongsong
xintongsong reviewed Jun 18, 2023
View reviewed changes
Copy link
Contributor

@xintongsong xintongsong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In addition to the two comments below, I added a fixup commit regarding NettyConnectionReaderRegistration. Please take a look.

@WencongLiu WencongLiu force-pushed the dev_FLINK_31642 branch 2 times, most recently from 24da729 to d66707a Compare June 19, 2023 07:27
@WencongLiu
Copy link
Contributor Author

WencongLiu commented Jun 19, 2023

@flinkbot run azure

TanYuxin-tyx
TanYuxin-tyx reviewed Jun 19, 2023
View reviewed changes
Copy link
Contributor

@TanYuxin-tyx TanYuxin-tyx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@WencongLiu Thanks for the contribution. I left some minor comments, please take a look again, thanks.

...he/flink/runtime/io/network/partition/hybrid/tiered/tier/memory/MemoryTierConsumerAgent.java
import java.util.concurrent.ExecutionException;

/** The data client is used to fetch data from memory tier. */
public class MemoryTierConsumerAgent implements TierConsumerAgent {
Copy link
Contributor

@TanYuxin-tyx TanYuxin-tyx Jun 19, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The class need not be public, package-level access is enough.

Copy link
Contributor Author

@WencongLiu WencongLiu Jun 19, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The test package needs it.

reswqa
reswqa reviewed Jun 19, 2023
View reviewed changes
Copy link
Member

@reswqa reswqa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good to me, I only left some comment, PTAL.

@WencongLiu
Copy link
Contributor Author

WencongLiu commented Jun 20, 2023

Thanks for the review from @TanYuxin-tyx and @reswqa ! I've made a round of changes. 🎉

reswqa
reswqa approved these changes Jun 20, 2023
View reviewed changes
Copy link
Member

@reswqa reswqa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update @WencongLiu! LGTM, merging % CI green,

@reswqa reswqa merged commit a83dd93 into apache:master Jun 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@xintongsong xintongsong xintongsong left review comments

@reswqa reswqa reswqa approved these changes

+1 more reviewer

@TanYuxin-tyx TanYuxin-tyx TanYuxin-tyx approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

component=Runtime/Network

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@WencongLiu @flinkbot @xintongsong @reswqa @TanYuxin-tyx