[FLINK-32314][rpc] Ignore classloading errors after actorsystem shutdown #22764
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The option was never empty.
Collaborator
XComp
approved these changes
Jun 13, 2023
Contributor
XComp
left a comment
XComp
left a comment
There was a problem hiding this comment.
I still feel like we should close FLINK-32314 as a duplicate of FLINK-32189, relabel this PR accordingly and document the reasoning for this change in FLINK-32189 (why we don't proceed further with finding the cause) since we collected most of the related test instabilities there.
I feel like we should be quite careful with documenting this specific issue properly.
flink-rpc/flink-rpc-akka/src/main/java/org/apache/flink/runtime/rpc/akka/RobustActorSystem.java
Show resolved
Hide resolved
flink-rpc/flink-rpc-akka/src/main/java/org/apache/flink/runtime/rpc/akka/RobustActorSystem.java
Show resolved
Hide resolved
...pc/flink-rpc-akka/src/test/java/org/apache/flink/runtime/rpc/akka/RobustActorSystemTest.java
Outdated
Show resolved
Hide resolved
This was referenced Jul 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stray threads in akka/netty can run into classloading errors because they aren't shut down (for some reason) despite the actor system having shut down.
Ignore errors in this specific situation.
This is primarily relevant for testing.