Skip to content

Conversation

@XComp
Copy link
Contributor

@XComp XComp commented Jun 26, 2023

What is the purpose of the change

AbstractZooKeeperHaServices is obsolete with the legacy ZK driver being gone. This PR help reducing the diff of FLINK-26522 PRs a bit.

Brief change log

  • Moves the ZooKeeperMultipleComponentLeaderElectionHaServices functionality into AbstractZooKeeperHaServices
  • Deletes ZooKeeperMultipleComponentLeaderElectionHaServices
  • Renames AbstractZooKeeperHaServices into ZooKeeperMultipleComponentLeaderElectionHaServices

Verifying this change

  • Any existing test should still pass

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): no
  • The public API, i.e., is any changed class annotated with @Public(Evolving): no
  • The serializers: no
  • The runtime per-record code paths (performance sensitive): no
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: yes
  • The S3 file system connector: no

Documentation

  • Does this pull request introduce a new feature? yes
  • If yes, how is the feature documented? not applicable

@flinkbot
Copy link
Collaborator

flinkbot commented Jun 26, 2023

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

…perMultipleComponentLeaderElectionHaServices

Signed-off-by: Matthias Pohl <matthias.pohl@aiven.io>
@XComp XComp merged commit a7bd6de into apache:master Jul 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants