Skip to content

Comments

[FLINK-32379][build] Skip archunit tests in java1X-target profiles#22884

Merged
snuyanzin merged 1 commit intoapache:masterfrom
snuyanzin:flink32379
Jun 28, 2023
Merged

[FLINK-32379][build] Skip archunit tests in java1X-target profiles#22884
snuyanzin merged 1 commit intoapache:masterfrom
snuyanzin:flink32379

Conversation

@snuyanzin
Copy link
Contributor

@snuyanzin snuyanzin commented Jun 27, 2023

What is the purpose of the change

Archunit generates different violation sets depending on bytecode.
The PR makes skipping of Archunit rule CONNECTOR_CLASSES_ONLY_DEPEND_ON_PUBLIC_API for JDK11, 17.

Verifying this change

This change is a trivial rework.
manually

mvn clean install -DskipTests -Dfast -Pjava17-target
mvn verify -pl flink-architecture-tests/flink-architecture-tests-production/ -Darchunit.freeze.store.default.allowStoreUpdate=false

or

mvn clean install -DskipTests -Dfast -Pjava11-target
mvn verify -pl flink-architecture-tests/flink-architecture-tests-production/ -Darchunit.freeze.store.default.allowStoreUpdate=false

Also there are a couple of nightly tests testing it

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): ( no)
  • The public API, i.e., is any changed class annotated with @Public(Evolving): ( no)
  • The serializers: ( no)
  • The runtime per-record code paths (performance sensitive): ( no
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: ( no )
  • The S3 file system connector: (no )

Documentation

  • Does this pull request introduce a new feature? ( no)
  • If yes, how is the feature documented? (not applicable )

@flinkbot
Copy link
Collaborator

flinkbot commented Jun 27, 2023

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

@snuyanzin
Copy link
Contributor Author

@flinkbot run azure

1 similar comment
@snuyanzin
Copy link
Contributor Author

@flinkbot run azure

@snuyanzin
Copy link
Contributor Author

the failure's root cause is another not related issue https://issues.apache.org/jira/browse/FLINK-32370

@snuyanzin snuyanzin requested a review from zentol June 28, 2023 13:10
@snuyanzin
Copy link
Contributor Author

@zentol could you have a look please since we discussed it a bit in jira

@zentol zentol self-assigned this Jun 28, 2023
@snuyanzin
Copy link
Contributor Author

Thanks for taking a look

@snuyanzin snuyanzin merged commit 74ae4b2 into apache:master Jun 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants