[FLINK-32379][build] Skip archunit tests in java1X-target profiles#22884
Merged
snuyanzin merged 1 commit intoapache:masterfrom Jun 28, 2023
Merged
[FLINK-32379][build] Skip archunit tests in java1X-target profiles#22884snuyanzin merged 1 commit intoapache:masterfrom
snuyanzin merged 1 commit intoapache:masterfrom
Conversation
Collaborator
Contributor
Author
|
@flinkbot run azure |
1 similar comment
Contributor
Author
|
@flinkbot run azure |
Contributor
Author
|
the failure's root cause is another not related issue https://issues.apache.org/jira/browse/FLINK-32370 |
Contributor
Author
|
@zentol could you have a look please since we discussed it a bit in jira |
zentol
approved these changes
Jun 28, 2023
Contributor
Author
|
Thanks for taking a look |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
Archunit generates different violation sets depending on bytecode.
The PR makes skipping of Archunit rule
CONNECTOR_CLASSES_ONLY_DEPEND_ON_PUBLIC_APIfor JDK11, 17.Verifying this change
This change is a trivial rework.
manually
or
Also there are a couple of nightly tests testing it
Does this pull request potentially affect one of the following parts:
@Public(Evolving): ( no)Documentation