Skip to content

Conversation

@zentol
Copy link
Contributor

@zentol zentol commented Jun 28, 2023

This class is useful for any rpc system implementation and should thus be shared.

@zentol zentol requested a review from XComp June 28, 2023 11:02
@flinkbot
Copy link
Collaborator

flinkbot commented Jun 28, 2023

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

@zentol zentol changed the title [FLINK-32467][rpc] Move CleanupOnCloseRpcSystem to rpc-core [FLINK-32467][rpc] Move common RPC utils to rpc-core Jun 28, 2023
Copy link
Contributor

@XComp XComp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM % CI 👍

@XComp
Copy link
Contributor

XComp commented Jun 29, 2023

was the force-push just for a rebase? Or did I miss something in my review?

@zentol
Copy link
Contributor Author

zentol commented Jun 29, 2023

rebase

@zentol
Copy link
Contributor Author

zentol commented Jun 29, 2023

In the hopes of getting a fix for the unstable jdbc e2e test...

@zentol
Copy link
Contributor Author

zentol commented Jun 29, 2023

great now I just collected another test instability 💢

@zentol zentol merged commit 167d564 into apache:master Jun 30, 2023
@zentol zentol deleted the 32467 branch July 3, 2023 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants