Skip to content

Conversation

@archzi
Copy link
Contributor

@archzi archzi commented Jul 12, 2023

What is the purpose of the change

This pull request replaces LeaderConnectionInfo with LeaderInformation

Brief change log

This change replaces all references to LeaderConnectionInfo with LeaderInformation.

Verifying this change

This change is already covered by existing tests, such as

  • EmbeddedHaServicesTest
  • LeaderChangeClusterComponentsTest
  • ZooKeeperLeaderElectionDriverTest

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): (no)
  • The public API, i.e., is any changed class annotated with @Public(Evolving): (no)
  • The serializers: (no)
  • The runtime per-record code paths (performance sensitive): (no)
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (no)
  • The S3 file system connector: (no)

Documentation

  • Does this pull request introduce a new feature? (no)
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)

@flinkbot
Copy link
Collaborator

flinkbot commented Jul 12, 2023

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

@XComp XComp merged commit f37d41c into apache:master Jul 13, 2023
Copy link
Contributor

@XComp XComp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the change. LGTM 👍

@XComp
Copy link
Contributor

XComp commented Jul 13, 2023

(sorry for not approving the PR before merging 😇 )

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants