-
Notifications
You must be signed in to change notification settings - Fork 13.9k
[FLINK-32680][streaming] Fix the messed up JobVertex name when the source nodes chained with a MultipleInput node. #23085
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
fa8959b to
161309c
Compare
wanglijie95
requested changes
Aug 1, 2023
Contributor
wanglijie95
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for creating this PR @JunRuiLee. I left some comments, PTAL.
...ming-java/src/main/java/org/apache/flink/streaming/api/graph/StreamingJobGraphGenerator.java
Outdated
Show resolved
Hide resolved
...-java/src/test/java/org/apache/flink/streaming/api/graph/StreamingJobGraphGeneratorTest.java
Outdated
Show resolved
Hide resolved
...-java/src/test/java/org/apache/flink/streaming/api/graph/StreamingJobGraphGeneratorTest.java
Show resolved
Hide resolved
…urce nodes chained with a MultipleInput node.
Contributor
Author
|
@wanglijie95 Thanks for CR and I've updated this pr, PTAL. |
wanglijie95
approved these changes
Aug 1, 2023
Contributor
wanglijie95
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
wanglijie95
pushed a commit
that referenced
this pull request
Aug 1, 2023
…urce nodes chained with a MultipleInput node. This closes #23085
wanglijie95
pushed a commit
that referenced
this pull request
Aug 1, 2023
…urce nodes chained with a MultipleInput node. This closes #23085
wanglijie95
pushed a commit
to wanglijie95/flink
that referenced
this pull request
Aug 23, 2023
…urce nodes chained with a MultipleInput node. This closes apache#23085
gpkc
pushed a commit
to aiven/flink
that referenced
this pull request
Mar 6, 2024
…urce nodes chained with a MultipleInput node. This closes apache#23085
gpkc
pushed a commit
to aiven/flink
that referenced
this pull request
Mar 6, 2024
…urce nodes chained with a MultipleInput node. This closes apache#23085
RocMarshal
pushed a commit
to RocMarshal/flink
that referenced
this pull request
May 9, 2024
…urce nodes chained with a MultipleInput node. This closes apache#23085
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
There is a bug in generating the JobVertex name when the source nodes are chained with a MultipleInput node, resulting in a messed up JobVertex name.
Brief change log
When generating a JobVertex name, filter the chained source by the vertex ID.
Verifying this change
This change can be verified by StreamingJobGraphGeneratorTest#testNamingOfChainedMultipleInputs
Does this pull request potentially affect one of the following parts:
@Public(Evolving): (yes / no)Documentation