Skip to content

Conversation

@JunRuiLee
Copy link
Contributor

What is the purpose of the change

There is a bug in generating the JobVertex name when the source nodes are chained with a MultipleInput node, resulting in a messed up JobVertex name.

Brief change log

When generating a JobVertex name, filter the chained source by the vertex ID.

Verifying this change

This change can be verified by StreamingJobGraphGeneratorTest#testNamingOfChainedMultipleInputs

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): (yes / no)
  • The public API, i.e., is any changed class annotated with @Public(Evolving): (yes / no)
  • The serializers: (yes / no / don't know)
  • The runtime per-record code paths (performance sensitive): (yes / no / don't know)
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (yes / no / don't know)
  • The S3 file system connector: (yes / no / don't know)

Documentation

  • Does this pull request introduce a new feature? (yes / no)
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)

@flinkbot
Copy link
Collaborator

flinkbot commented Jul 27, 2023

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

@JunRuiLee JunRuiLee force-pushed the FLINK-32680 branch 2 times, most recently from fa8959b to 161309c Compare August 1, 2023 03:48
Copy link
Contributor

@wanglijie95 wanglijie95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for creating this PR @JunRuiLee. I left some comments, PTAL.

…urce nodes chained with a MultipleInput node.
@JunRuiLee
Copy link
Contributor Author

@wanglijie95 Thanks for CR and I've updated this pr, PTAL.

Copy link
Contributor

@wanglijie95 wanglijie95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

wanglijie95 pushed a commit that referenced this pull request Aug 1, 2023
…urce nodes chained with a MultipleInput node.

This closes #23085
wanglijie95 pushed a commit that referenced this pull request Aug 1, 2023
…urce nodes chained with a MultipleInput node.

This closes #23085
wanglijie95 pushed a commit to wanglijie95/flink that referenced this pull request Aug 23, 2023
…urce nodes chained with a MultipleInput node.

This closes apache#23085
@JunRuiLee JunRuiLee deleted the FLINK-32680 branch August 31, 2023 04:04
gpkc pushed a commit to aiven/flink that referenced this pull request Mar 6, 2024
…urce nodes chained with a MultipleInput node.

This closes apache#23085
gpkc pushed a commit to aiven/flink that referenced this pull request Mar 6, 2024
…urce nodes chained with a MultipleInput node.

This closes apache#23085
RocMarshal pushed a commit to RocMarshal/flink that referenced this pull request May 9, 2024
…urce nodes chained with a MultipleInput node.

This closes apache#23085
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants