Skip to content

[FLINK-32144][connector/filesystem][test] Create a new minicluser instead of using MiniClusterExtension in tests that would kill JM/TM#23125

Merged
PatrickRen merged 1 commit into
apache:masterfrom
wanglijie95:FLINK-32144
Aug 8, 2023
Merged

Conversation

@wanglijie95
Copy link
Copy Markdown
Contributor

@wanglijie95 wanglijie95 commented Aug 3, 2023

What is the purpose of the change

Fix FLINK-32144, fix the unstable tests in FileSourceTextLinesITCase

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): (no)
  • The public API, i.e., is any changed class annotated with @Public(Evolving): (no)
  • The serializers: (no)
  • The runtime per-record code paths (performance sensitive): (no)
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (no)
  • The S3 file system connector: (no)

Documentation

  • Does this pull request introduce a new feature? (no)
  • If yes, how is the feature documented? (not applicable)

@wanglijie95
[FLINK-32144][connector/filesystem][test] Create a new minicluser ins…
179d15c 
…tead of using MiniClusterExtension in tests that would kill JM/TM

Currently, MiniClusterExtension creates only one MiniCluster instance for each test class, all tests in the test class share one minicluster instance.
So in the tests that would kill JM/TM, we have to manually create a new minicluster instance to avoid affecting other tests in the same class.
@wanglijie95 wanglijie95 requested a review from PatrickRen August 3, 2023 02:13
@flinkbot
Copy link
Copy Markdown
Collaborator

flinkbot commented Aug 3, 2023 •
edited
Loading

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

PatrickRen
PatrickRen approved these changes Aug 8, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@PatrickRen PatrickRen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@wanglijie95 Thanks for the patch! LGTM.

@PatrickRen PatrickRen merged commit fa61dd4 into apache:master Aug 8, 2023
@wanglijie95 wanglijie95 deleted the FLINK-32144 branch August 8, 2023 06:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@PatrickRen PatrickRen PatrickRen approved these changes

Assignees

No one assigned

Labels

component=Connectors/FileSystem component=Tests

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@wanglijie95 @flinkbot @PatrickRen