Skip to content

Conversation

@xuzifu666
Copy link
Member

@xuzifu666 xuzifu666 commented Aug 4, 2023

What is the purpose of the change

fix resouces not fix in testcase, in some test case did not close resource in right way,this can cause connection leak in extreme scenarios. so need make a pr to fix it

Brief change log

(for example:)

  • The TaskInfo is stored in the blob store on job creation time as a persistent artifact
  • Deployments RPC transmits only the blob storage reference
  • TaskManagers retrieve the TaskInfo from the blob cache

Verifying this change

Please make sure both new and modified tests in this PR follows the conventions defined in our code quality guide: https://flink.apache.org/contributing/code-style-and-quality-common.html#testing

(Please pick either of the following options)

This change is a trivial rework / code cleanup without any test coverage.

(or)

This change is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(example:)

  • Added integration tests for end-to-end deployment with large payloads (100MB)
  • Extended integration test for recovery after master (JobManager) failure
  • Added test that validates that TaskInfo is transferred only once across recoveries
  • Manually verified the change by running a 4 node cluster with 2 JobManagers and 4 TaskManagers, a stateful streaming program, and killing one JobManager and two TaskManagers during the execution, verifying that recovery happens correctly.

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): (yes / no)
  • The public API, i.e., is any changed class annotated with @Public(Evolving): (yes / no)
  • The serializers: (yes / no / don't know)
  • The runtime per-record code paths (performance sensitive): (yes / no / don't know)
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (yes / no / don't know)
  • The S3 file system connector: (yes / no / don't know)

Documentation

  • Does this pull request introduce a new feature? (yes / no)
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)

@xuzifu666 xuzifu666 closed this Aug 4, 2023
@xuzifu666 xuzifu666 reopened this Aug 7, 2023
@xuzifu666 xuzifu666 closed this Aug 7, 2023
@xuzifu666 xuzifu666 reopened this Aug 7, 2023
@flinkbot
Copy link
Collaborator

flinkbot commented Aug 7, 2023

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

@XComp
Copy link
Contributor

XComp commented Aug 7, 2023

@xuzifu666 Thanks for the PR. But I'm wondering where you see the risk of leaking resources in the test methods you touched. It looks like you only touched code segments where the reader/writer was actually closed through a close() call. In the end, you replaced those close calls with try blocks (which do the same thing: calling close() on the AutoCloseable instance). Or do I overlook something? 🤔

If not, I would tend to close this PR without merging. It doesn't bring any new value but might make it harder to backport code changes (due to the difference between master and the release branches). WDYT? :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants