Skip to content

Conversation

@GOODBOY008
Copy link
Member

Fix en-doc SHOW CREATE TABLE usage.

@flinkbot
Copy link
Collaborator

flinkbot commented Aug 7, 2023

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

@GOODBOY008
Copy link
Member Author

@leonardBang Pls cc.

Copy link
Contributor

@RocMarshal RocMarshal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @GOODBOY008 for your contribution.
I left a minor comment, PTAL ~


```sql
SHOW CREATE TABLE
SHOW CREATE TABLE [catalog_name.][db_name.]table_name
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
SHOW CREATE TABLE [catalog_name.][db_name.]table_name
SHOW CREATE TABLE [[catalog_name.]db_name.]table_name

Copy link
Member Author

@GOODBOY008 GOODBOY008 Aug 7, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@RocMarshal [[catalog_name.]db_name.] is wrong semantics.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[[catalog_name.]db_name.]table_name is better one as [] means optional and flink sql supports full qualified table name like mycatalog.mydb.mytable and table with database prefix like mydb.mytable or even single table likemytable

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@RocMarshal
Copy link
Contributor

RocMarshal commented Aug 8, 2023

Thanks @GOODBOY008 for the update & @leonardBang review.
Maybe we need change the JIRA ticket title & the PR title to Fix table identifier format in docs or any-titles proper.
Because the rest of table identifier reference was updated.

@GOODBOY008
Copy link
Member Author

GOODBOY008 commented Aug 8, 2023

@leonardBang @RocMarshal I found sqlserver offical doc use this. Although the explanation is very redundant, it is very clear.
企业微信截图_16914603187821

@leonardBang
Copy link
Contributor

@leonardBang @RocMarshal I found sqlserver offical doc use this. Although the explanation is very redundant, it is very clear. 企业微信截图_16914603187821

+1, the sqlserver way is more friendly to users.

@GOODBOY008
Copy link
Member Author

@leonardBang @RocMarshal In this pr, just modify show create table use [[catalog_name.]db_name.]table_name. Please code review.

Copy link
Contributor

@RocMarshal RocMarshal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @GOODBOY008 for the update.
LGTM +1.
CC @leonardBang

Copy link
Contributor

@leonardBang leonardBang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @GOODBOY008 and @RocMarshal for the contribution, LGTM

@leonardBang leonardBang merged commit d9342f5 into apache:master Nov 2, 2023
@GOODBOY008 GOODBOY008 deleted the FLINK-32767 branch July 18, 2024 01:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants