-
Notifications
You must be signed in to change notification settings - Fork 13.9k
[FLINK-32767][doc] Fix en-doc SHOW CREATE TABLE usage #23152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@leonardBang Pls cc. |
RocMarshal
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @GOODBOY008 for your contribution.
I left a minor comment, PTAL ~
|
|
||
| ```sql | ||
| SHOW CREATE TABLE | ||
| SHOW CREATE TABLE [catalog_name.][db_name.]table_name |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| SHOW CREATE TABLE [catalog_name.][db_name.]table_name | |
| SHOW CREATE TABLE [[catalog_name.]db_name.]table_name |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@RocMarshal [[catalog_name.]db_name.] is wrong semantics.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[[catalog_name.]db_name.]table_name is better one as [] means optional and flink sql supports full qualified table name like mycatalog.mydb.mytable and table with database prefix like mydb.mytable or even single table likemytable
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| # test create with database name |
|
Thanks @GOODBOY008 for the update & @leonardBang review. |
|
@leonardBang @RocMarshal I found sqlserver offical doc use this. Although the explanation is very redundant, it is very clear. |
+1, the sqlserver way is more friendly to users. |
033ab0c to
58d0f6d
Compare
|
@leonardBang @RocMarshal In this pr, just modify |
RocMarshal
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @GOODBOY008 for the update.
LGTM +1.
CC @leonardBang
58d0f6d to
ff9f636
Compare
leonardBang
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @GOODBOY008 and @RocMarshal for the contribution, LGTM


Fix en-doc SHOW CREATE TABLE usage.