[BP-1.16][FLINK-32751][runtime] Refactors close handling to CollectSinkOperatorCoordinator #23238
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
XComp
changed the title
Collaborator
…able case-specific logging shutdownNow() is added to immediately stop any already submitted requests. That makes the close logic more explicit rather than relying on the Runnables to finish implicitly through the connection loss. Any ongoing requests are now also cancelled. This allows us to log specific cases of unexpected errors properly.
XComp
force-pushed
the
FLINK-32751-1.16
branch
from
da9d0ef to
96e7446
Compare
Contributor
Author
|
I dropped the JUnit5 migration hotfix because it caused compilation errors and it's not needed for FLINK-32751 |
Contributor
Author
|
@flinkbot run azure |
gpkc
pushed a commit
to aiven/flink
that referenced
this pull request
Mar 6, 2024
…rCoordinator (apache#23238) shutdownNow() is added to immediately stop any already submitted requests. That makes the close logic more explicit rather than relying on the Runnables to finish implicitly through the connection loss. Any ongoing requests are now also cancelled. This allows us to log specific cases of unexpected errors properly.
gpkc
pushed a commit
to aiven/flink
that referenced
this pull request
Mar 6, 2024
…rCoordinator (apache#23238) shutdownNow() is added to immediately stop any already submitted requests. That makes the close logic more explicit rather than relying on the Runnables to finish implicitly through the connection loss. Any ongoing requests are now also cancelled. This allows us to log specific cases of unexpected errors properly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1.16 backport PR of parent PR #23180. No conflicts encountered while backporting.